Timestamp field type misses schema for value

@claudiu.cristea,

Thanks for the patch. Your patch applied cleanly. PFA for the same.

Schema for timestamp has been added core.data_types.schema.yml file

This doesn't live in the datetime module.

@Venkatesh Rajan.J: posting screenshots of a succesfully applying patch is not useful. The fact that tests passed already prove that the patch applies successfully.

+++ b/core/config/schema/core.data_types.schema.yml
@@ -743,6 +743,16 @@ field.value.float:
+      type: integer

Actually, this is not just a integer, it's a UNIX timestamp. Which for example means it can't go negative.

i.e. the current config schema refers to:

integer:
  label: 'Integer'
  class: '\Drupal\Core\TypedData\Plugin\DataType\IntegerData'

But this value is actually \Drupal\Core\TypedData\Plugin\DataType\Timestamp.

Because:

class TimestampItem extends FieldItemBase {

  /**
   * {@inheritdoc}
   */
  public static function propertyDefinitions(FieldStorageDefinitionInterface $field_definition) {
    $properties['value'] = DataDefinition::create('timestamp')
      ->setLabel(t('Timestamp value'))
      ->setRequired(TRUE);
    return $properties;
  }

Actually, this is not just a integer, it's a UNIX timestamp. Which for example means it can't go negative.

If a system support signed `time_t`, then timestamps can be negative. A negative number represents date/times before 1970-01-01 (see some of the issues about timestamps and the 1901 problem). The 2038 problem is 2^31-1, rolling over into 1901. The Wikipedia article has some more details.

I'm wondering if we need a decent way to detect missing schema definitions. Maybe a meta parent issue to remove most of the wildcards so we can detect problems?

Maybe a meta parent issue to remove most of the wildcards so we can detect problems?

+1

+++ b/core/config/schema/core.data_types.schema.yml
@@ -757,6 +757,16 @@ field.value.float:
+# Schema for the configuration of the Timestamp field type.
+
+field.value.timestamp:

I don't think the blank line there is needed.

Needs follow-up for #7/#8. But this patch is ready.

Adding review credit for @Wim Leers for reviews that shaped the patch

Committed 1872e83 and pushed to 8.5.x.

Cherry-picked as c671146 and pushed to 8.4.x

Can we get the follow-up for #7 and #8?

Thanks

Created #2933548: [META] Find all fields with missing/improper schemas.