At long last, let's do it. Mark it stable!

CommentFileSizeAuthor
#2 2931165.patch368 bytesheddn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

heddn created an issue. See original summary.

heddn’s picture

Status: Active » Needs review
Related issues: +#2859225: [policy, no patch] Mark Migrate (not Migrate Drupal) as Stable
FileSize
368 bytes
phenaproxima’s picture

+++ b/core/modules/migrate/migrate.info.yml
@@ -1,6 +1,6 @@
+package: Migration

I'm not sure the package should be Migration. This will bring it in line with Migrate Plus and Migrate Tools (i.e., contrib), so it makes sense...just thought I'd call it out here. What do others think?

heddn’s picture

I was asked why use 'Migration' for the package name. I did that because that's what it is. There's already precedent in core for assigning a package name that isn't 'core'. Locale and others use 'Multilingual'.

maxocub’s picture

I like Migration for the package. Beside the multilingual package, there's also the field types modules and web services modules that have there own packages where they could be mixed up with contrib modules.

quietone’s picture

My two cents: I like 'Migration' as well.

Gábor Hojtsy’s picture

Status: Needs review » Postponed (maintainer needs more info)

I agree this is a bunch of modules in core that are related and do have tightly related contribs as well. As per #2859225: [policy, no patch] Mark Migrate (not Migrate Drupal) as Stable we should mark RC, but then this issue has stable. Can we agree in #2859225: [policy, no patch] Mark Migrate (not Migrate Drupal) as Stable to mark stable right away? Sounds like there was no concerns that would warrant it to be RC.

heddn’s picture

I've updated the title and wording in the policy issue.

heddn’s picture

Status: Postponed (maintainer needs more info) » Needs review

I think this can go back to NR?

heddn’s picture

phenaproxima’s picture

Alright; I'm OK with Migration as the package name.

masipila’s picture

Migration is also my preference for the package name.

maxocub’s picture

As mentioned in the policy issue, I think the Migrate API is ready to go stable. I think we discussed in one of our meetings with either @xjm or @webchick that avoiding RC was OK here.

So I think this patch is ready.

phenaproxima’s picture

Status: Needs review » Reviewed & tested by the community

*deep breath*

xjm’s picture

This is a really exciting milestone. :) (Advanced apologies if I don't tweet and cheer and announce publicly just yet; I'm pretty sure most people will not understand the nuance between "Migrate" and "Migrate Drupal" so I would not want them to misunderstand and run into problems because of it.) I think "Migration" is probably fine as a package name.

This has been discussed in #2859225: [policy, no patch] Mark Migrate (not Migrate Drupal) as Stable and by the committer team last month. @Gábor Hojtsy confirmed with the team that there are no additional things requiring BC breaks for the Migrate API. Also just going to repeat here what @catch wrote:

Although I think we should leave #2748609: [meta] Preserving auto-increment IDs on migration is fragile open, I also think the audit issue is enough to make it not block migrate being stable.

The only remaining concern I'd have is that it looks like we're going to need an API addition in order to resolve the translated node IDs issues, but that's absolutely going to be an API addition so bc shouldn't be an issue there.

Going to check with him one more time before committing.

xjm’s picture

OK, committed and pushed to 8.6.x and cherry-picked to 8.5.x. Yay!

xjm’s picture

Status: Reviewed & tested by the community » Fixed

VCS integration is a bit backlogged presumably from 8.6.x being branched, but the commits are there in the main repo. :)

mikeryan’s picture

Status: Fixed » Reviewed & tested by the community

Congrats to everyone who pushed this over the finish line!

larowlan’s picture

Status: Reviewed & tested by the community » Fixed

fixing status

congrats all!

heddn’s picture

Stats of how what took to get here (as of 2017/01/11)

  • 1183 closed issues tagged to the migrate subsystem
  • 4+ years
  • 100% turnover in the subsystem maintainers
  • 2 years and 2 months after 8.0.0 was tagged

Thank you EVERYONE!

  • xjm committed b0542ce on 8.6.x
    Issue #2931165 by heddn, phenaproxima, maxocub, quietone, masipila: Mark...

  • xjm committed 8351e1b on 8.5.x
    Issue #2931165 by heddn, phenaproxima, maxocub, quietone, masipila: Mark...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.