Problem/Motivation

Based on the guidance in https://www.drupal.org/core/experimental & https://www.drupal.org/node/2735059, as maintainers of Migrate, we'd like to propose moving the Migrate module (not migrate drupal) as Stable during the 8.5.x lifetime.

Proposed resolution

Change the version as Stable

Remaining tasks

All Migrate criticals must be fixed

Approvals

Comments

heddn created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Category: Task » Plan
Parent issue: » #2735059: [META] Stabilize the older Drupal to newer Drupal migration system
Related issues: -#2735059: [META] Stabilize the older Drupal to newer Drupal migration system +#2683435: CCK does not exist in Drupal 7, rename Migrate's cckfield plugins to field plugins, +#2820490: FormatDate process plugin, +#2748609: [meta] Preserving auto-increment IDs on migration is fragile

Adding some blockers in the relationships.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Issue summary: View changes
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented

Do we think the autoincrement problem is the last thing blocking this?

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented

I haven't conferred with the other maintainers, but I think that sounds right. We're currently waiting on #2876085: Before upgrading, audit for potential ID conflicts at a minimum.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Issue summary: View changes

I've reviewed the dependencies and we are down to #2876085: Before upgrading, audit for potential ID conflicts and its parent meta: #2748609: [meta] Preserving auto-increment IDs on migration is fragile. I've also gone through and triaged and confirmed we have everything tagged as 'Migrate critical' and 'Migrate API' that is blocking a release candidate. We might end up opening a follow-up issue to handle i18n and revisions. But we're down to just a handful before the API is DONE.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Title: Mark Migrate (not Migrate Drupal) as Release Candidate » [policy, no patch] Mark Migrate (not Migrate Drupal) as Release Candidate
Version: 8.5.x-dev » 8.4.x-dev
quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Issue summary: View changes

Updated IS to correct spelling of my first name.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Issue summary: View changes

This is now unblocked I think.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Status: Active » Needs review
Related issues: +#2931165: Mark Migrate (API) as stable

I've opened up #2931165: Mark Migrate (API) as stable to get the ball rolling on the actual work involved here.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Issue summary: View changes
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented

Approved.

There are still major bugs that need to get worked out, but nothing that needs to block stability. Onward and upward.

maxocub’s picture

maxocub CreditAttribution: maxocub as a volunteer commented
Issue summary: View changes

Approved.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Issue summary: View changes

Updating the IS to mark my approval.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Issue summary: View changes

And, restoring @maxocub's approval in the IS.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented

Approved

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Issue summary: View changes
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Issue summary: View changes
masipila’s picture

masipila CreditAttribution: masipila as a volunteer commented

Approved.

masipila’s picture

masipila CreditAttribution: masipila as a volunteer commented
Issue summary: View changes
quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Issue summary: View changes

Me too. I had some concerns this morning when I first read https://www.drupal.org/core/experimental. I talked to heddn, then did something else, and then re-read everything. Seems I got it wrong and didn't read the core/experimental correctly. (I must admit it is difficult to always think clearly due to my lower back injury).

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Issue summary: View changes
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Issue summary: View changes
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented

Although I think we should leave #2748609: [meta] Preserving auto-increment IDs on migration is fragile open, I also think the audit issue is enough to make it not block migrate being stable.

The only remaining concern I'd have is that it looks like we're going to need an API addition in order to resolve the translated node IDs issues, but that's absolutely going to be an API addition so bc shouldn't be an issue there.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Title: [policy, no patch] Mark Migrate (not Migrate Drupal) as Release Candidate » [policy, no patch] Mark Migrate (not Migrate Drupal) as Stable
Issue summary: View changes
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

As per the migrate triage sheet currently at https://docs.google.com/spreadsheets/d/16SwQsp7nF1UKrZQCNdPYML_wi53ZjM1e... there are two probable BC breaks with migrate. Is that up to date?

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented

I reviewed the two issues and remove the BC break tag on them. They can be resolved without BC.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented

I reviewed the two issues and remove the BC break tag on them. They can be resolved without BC.

Agreed. I don't think either of those needs to block Migrate API stability.

maxocub’s picture

maxocub CreditAttribution: maxocub as a volunteer commented

I agree there won't be anymore BC breaks in Migrate API and that it can go stable.

masipila’s picture

masipila CreditAttribution: masipila as a volunteer commented

+1 from me too.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented

+1 from me as well.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Version: 8.4.x-dev » 8.5.x-dev
Status: Needs review » Fixed

Done!

It looks like there are separate issues for Migrate Drupal and Migrate Drupal UI, so I think this one can be marked fixed?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.