Closed (fixed)
Project:
Drupal core
Version:
8.5.x-dev
Component:
migration system
Priority:
Normal
Category:
Plan
Assigned:
Unassigned
Reporter:
Created:
9 Mar 2017 at 14:31 UTC
Updated:
26 Jan 2018 at 22:09 UTC
Jump to comment: Most recent
Comments
Comment #2
heddnAdding some blockers in the relationships.
Comment #3
heddnComment #4
xjmDo we think the autoincrement problem is the last thing blocking this?
Comment #5
heddnI haven't conferred with the other maintainers, but I think that sounds right. We're currently waiting on #2876085: Before upgrading, audit for potential ID conflicts at a minimum.
Comment #7
heddnI've reviewed the dependencies and we are down to #2876085: Before upgrading, audit for potential ID conflicts and its parent meta: #2748609: [meta] Preserving auto-increment IDs on migration is fragile. I've also gone through and triaged and confirmed we have everything tagged as 'Migrate critical' and 'Migrate API' that is blocking a release candidate. We might end up opening a follow-up issue to handle i18n and revisions. But we're down to just a handful before the API is DONE.
Comment #8
heddnComment #9
quietone commentedUpdated IS to correct spelling of my first name.
Comment #10
heddnThis is now unblocked I think.
Comment #11
heddnI've opened up #2931165: Mark Migrate (API) as stable to get the ball rolling on the actual work involved here.
Comment #12
heddnComment #13
phenaproximaApproved.
There are still major bugs that need to get worked out, but nothing that needs to block stability. Onward and upward.
Comment #14
maxocub commentedApproved.
Comment #15
phenaproximaUpdating the IS to mark my approval.
Comment #16
phenaproximaAnd, restoring @maxocub's approval in the IS.
Comment #17
heddnApproved
Comment #18
heddnComment #19
heddnComment #20
masipila commentedApproved.
Comment #21
masipila commentedComment #22
quietone commentedMe too. I had some concerns this morning when I first read https://www.drupal.org/core/experimental. I talked to heddn, then did something else, and then re-read everything. Seems I got it wrong and didn't read the core/experimental correctly. (I must admit it is difficult to always think clearly due to my lower back injury).
Comment #23
quietone commentedComment #24
larowlanComment #25
catchAlthough I think we should leave #2748609: [meta] Preserving auto-increment IDs on migration is fragile open, I also think the audit issue is enough to make it not block migrate being stable.
The only remaining concern I'd have is that it looks like we're going to need an API addition in order to resolve the translated node IDs issues, but that's absolutely going to be an API addition so bc shouldn't be an issue there.
Comment #26
heddnComment #27
gábor hojtsyAs per the migrate triage sheet currently at https://docs.google.com/spreadsheets/d/16SwQsp7nF1UKrZQCNdPYML_wi53ZjM1e... there are two probable BC breaks with migrate. Is that up to date?
Comment #28
heddnI reviewed the two issues and remove the BC break tag on them. They can be resolved without BC.
Comment #29
phenaproximaAgreed. I don't think either of those needs to block Migrate API stability.
Comment #30
maxocub commentedI agree there won't be anymore BC breaks in Migrate API and that it can go stable.
Comment #31
masipila commented+1 from me too.
Comment #32
quietone commented+1 from me as well.
Comment #33
xjmDone!
It looks like there are separate issues for Migrate Drupal and Migrate Drupal UI, so I think this one can be marked fixed?