Some email delivery service like Sparkpost, Sendgrid, etc... are no more using TLS protocol version 1.0 (they now use 1.1, 1.2...)->Normal.

Swiftmailer library 5.4.5 (which is required by the module swiftmailer 8.x-1.0-beta2) is using TLS 1.0 maximum.

The update of Swiftmailer library 6.1 (+) is now using TLS protocol 1.1, 1.2 ...).

CommentFileSizeAuthor
#26 2930358-26.patch8.47 KBgg4
#26 interdiff--2930358--24-26.txt249 bytesgg4
#24 2930358-24.patch8.43 KBgg4
#24 interdiff--2930358--20-24.txt726 bytesgg4
#20 2930358-20.patch8.41 KBgg4
#19 2930358-19.patch4.65 KBgg4
#17 2930358-17.patch1.31 KBgg4
#15 2930358-15.patch753 bytesgg4
#13 interdiff--2930358--10-13.txt330 bytesgg4
#13 2930358-13.patch1.73 KBgg4
#10 2930358-10.patch1.69 KBsam152
#8 swiftmailer-6--2930358-8.patch703 bytesgg4
#8 interdiff--2930358--2-8.txt576 bytesgg4
#6 swiftmailer-6--2930358-6.patch704 bytesgg4
#6 interdiff--2930358--2-6.txt577 bytesgg4
#2 2930358.patch338 bytesheddn

Comments

webflo created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Active » Needs review
StatusFileSize
new 2930358.patch338 bytes

Let's see what happens?

Status: Needs review » Needs work

The last submitted patch, 2: 2930358.patch, failed testing. View results

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs work » Postponed

Postponed on #2755401: Upgrade EmailValidator to 2.x.

gg4’s picture

gg4 commented
Status: Postponed » Needs work

#2755401: Upgrade EmailValidator to 2.x is RTBC, might be a good time to pick this back up.

gg4’s picture

gg4 commented
Status: Needs work » Needs review
StatusFileSize
new interdiff--2930358--2-6.txt577 bytes
new swiftmailer-6--2930358-6.patch704 bytes

Swift Mailer 6 will require "php": ">=7.0.0",.

Status: Needs review » Needs work

The last submitted patch, 6: swiftmailer-6--2930358-6.patch, failed testing. View results

gg4’s picture

gg4 commented
StatusFileSize
new interdiff--2930358--2-8.txt576 bytes
new swiftmailer-6--2930358-8.patch703 bytes
sam152’s picture

sam152 commented

I need this patch pretty badly. We have a site that is filling up queues with unsendable emails because cores email validation library doesn't match the regex swiftmailer uses to validate emails in version 5. Version 6 fixes this by using the same email validator it suggests people use in the documentation (https://github.com/swiftmailer/swiftmailer/commit/e7cf4bd807b44be83d8922...).

sam152’s picture

sam152 commented
Status: Needs work » Needs review
StatusFileSize
new 2930358-10.patch1.69 KB

With the new php version requirement, switching the version of phpunit being used in the test cases.

Status: Needs review » Needs work

The last submitted patch, 10: 2930358-10.patch, failed testing. View results

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Looks like this gets confused about mailsystem? It's only in the info.yml but not in composer.json, should be in there as well?

gg4’s picture

gg4 commented
Status: Needs work » Needs review
StatusFileSize
new 2930358-13.patch1.73 KB
new interdiff--2930358--10-13.txt330 bytes

Status: Needs review » Needs work

The last submitted patch, 13: 2930358-13.patch, failed testing. View results

gg4’s picture

gg4 commented
Status: Needs work » Needs review
StatusFileSize
new 2930358-15.patch753 bytes

Status: Needs review » Needs work

The last submitted patch, 15: 2930358-15.patch, failed testing. View results

gg4’s picture

gg4 commented
Status: Needs work » Needs review
StatusFileSize
new 2930358-17.patch1.31 KB

Status: Needs review » Needs work

The last submitted patch, 17: 2930358-17.patch, failed testing. View results

gg4’s picture

gg4 commented
Status: Needs work » Needs review
StatusFileSize
new 2930358-19.patch4.65 KB
gg4’s picture

gg4 commented
StatusFileSize
new 2930358-20.patch8.41 KB

Status: Needs review » Needs work

The last submitted patch, 20: 2930358-20.patch, failed testing. View results

gg4’s picture

gg4 commented
Status: Needs work » Needs review

The Swift_MailTransport class and ::newInstance() methods have been removed in SwiftMailer version 6.0.x. Swift_MailTransport had been used previously in this module for the native (PHP) transport method. #20 removes the native transport option, sets Sendmail as the new default, and adds an update hook to set the transport config to Sendmail, if previously set to native. Not sure if this is ideal, but test at least pass at this point -- #20 is rather untested otherwise.

webflo’s picture

webflo commented

Awesome, thanks for working on this.

  1. +++ b/config/install/swiftmailer.transport.yml
@@ -1,4 +1,4 @@
+transport: Sendmail

    Sendmail should be lowercase, because SWIFTMAILER_TRANSPORT_SENDMAIL contains a lowercase value. 

  2. +++ b/swiftmailer.install
@@ -56,3 +56,14 @@ function swiftmailer_update_8102() {
+    $config->set('transport', 'Sendmail');

    lowecase

gg4’s picture

gg4 commented
StatusFileSize
new interdiff--2930358--20-24.txt726 bytes
new 2930358-24.patch8.43 KB

Status: Needs review » Needs work

The last submitted patch, 24: 2930358-24.patch, failed testing. View results

gg4’s picture

gg4 commented
Status: Needs work » Needs review
StatusFileSize
new interdiff--2930358--24-26.txt249 bytes
new 2930358-26.patch8.47 KB
gg4’s picture

gg4 commented
Priority: Normal » Major
Issue summary: View changes
webflo’s picture

webflo commented
Version: 8.x-1.x-dev » 8.x-2.x-dev
Status: Needs review » Fixed

Commit ef3092e

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

golddragon007’s picture

golddragon007 commented

This successfully broke the mail sending for us on production.

ivnish’s picture

ivnish
he/him
commented

Same, but we get this "new feature" on testing