[D8] Allow username on the registration form

That patch is corrupted.

Works well. Just some nits:

1. +++ b/config/install/email_registration.settings.yml
   @@ -1 +1,2 @@
   +allow_username_registration: FALSE
   

   In Yaml syntax TRUE/FALSE should be lowercased. Please change also the line above if we're always touch the file.

2. +++ b/config/schema/email_registration.schema.yml
   @@ -5,3 +5,6 @@ email_registration.settings:
   +      label: 'Allow users to log in with e-mail or username.'
   

   Maybe "Allow also username login" or "Allow login also with username"?

3. +++ b/email_registration.module
   @@ -193,6 +195,12 @@ function email_registration_form_user_admin_settings_alter(&$form, FormStateInte
   +    '#description' => t('If ticked, a text entry field will be displayed on the new user registration form to allow users to enter their desired user name.'),
   

   s/ticked/checked

Great. Thank you!

Good idea but it needs test coverage before getting in

Rerolled against latest HEAD.

Rerolled against latest HEAD.

It needs upgrade hook as well

@andypost, here are the update path & tests.

The failure was cause because Drupal 8.8.x ran on PHP 5. This not possible anymore.

I've adjusted testing for the project to use PHP 7 for the future. Thanks for your help, claudiu.cristea!

Here's a reroll as the change to config/schema/email_registration.schema.yml didn't apply.

Also I'm not sure about this text:

+    allow_username_registration:
+      type: boolean
+      label: 'Allow login also with username.'

Shouldn't the label be "Allow registration also with username." ?

Yep it needs better naming as well as update hook should become hook_post_update_NAME()

1. +++ b/email_registration.install
   @@ -33,3 +33,12 @@ function email_registration_update_8100() {
   +function email_registration_update_8101() {
   +  \Drupal::configFactory()->getEditable('email_registration.settings')
   

   better to use hook_post_update_NAME() for config updates

2. +++ b/email_registration.module
   @@ -122,11 +122,14 @@ function email_registration_cleanup_username($name) {
    function email_registration_form_user_form_alter(&$form, FormStateInterface $form_state) {
   ...
   +  if (!\Drupal::config('email_registration.settings')->get('allow_username_registration')) {
   +    $form['account']['name']['#type'] = 'value';
   

   the config name is confusing, maybe kind of "alter_user_form"

Thanks for the feedback, andypost!

I researched hook_post_update on the doc page and this stackexchange post. It seems config/content entities are best to update via hook_post_update_NAME in part because of the order it runs and how to run it.

The great side of post update hooks is less collision in patches comparing to hook_update_n

Shouldn't the label be "Allow registration also with username." ?

and

the config name is confusing, maybe kind of "alter_user_form"

Finally I opted for this name:

require_username_on_registration:
  type: boolean
  label: 'Require also the username on registration'

Moved the update path to post update.

Rerolled against latest HEAD.

Fix syntax error in rerolled.

Re-rolling patch as it wasn't applying to latest version.

I know this is an older issue but it seems to be in a resolved state at this point. With the current 8.x release, to allow for anonymous users to edit/set their user name you just need to give the anonymous user permission to "change own username". Can others confirm that this issue is resolved?

The patch here still applies to 8.x-1.x branch tip, so it has not been merged. It would be great if anyone interested in this feature could articulate how this is different than what is possible in core.

It seems this is needed if you want the Username field to be empty when the user first visits the registration form. I can confirm that the most recent patch posted in #23 works with the current development version of this module.

Thanks, Ryan for that feedback and everyone along the way for your work on this issue!

Now fixed.