Problem/Motivation

In #2470882: Implement running migration processes through the UI, we discovered that the limit wasn't getting honored. So at the last minute, that feature was removed. Let's re-add it and figure out why it isn't working.

Proposed resolution

Remaining tasks

  • Investigate.
  • Fix it.
  • Test it.
  • Reap profits.

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 interdiff_4_7.txt3.25 KBkriboogh
#7 migrate_tools-ui-limit-2924298-7.patch1.99 KBkriboogh
#4 migrate_tools-migrate-ui-limit-2924298-4.patch2.49 KBkriboogh
#4 migrate_tools-migrate-ui-limit-2924298-4.patch2.49 KBkriboogh

Comments

heddn created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Related issues: +#2470882: Implement running migration processes through the UI
Ben Buske’s picture

Ben Buske commented

FYI: If the limit is smaller than the batch size it works.

kriboogh’s picture

kriboogh commented
StatusFileSize
new migrate_tools-migrate-ui-limit-2924298-4.patch2.49 KB
new migrate_tools-migrate-ui-limit-2924298-4.patch2.49 KB

Limit recalculated every batch run.

As a side fix, I also fixed the catch exception to handle all exceptions, so you won't get a white page if your migration somehow fails.

kriboogh’s picture

kriboogh commented
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Active » Needs work

Let's move the exception stuff into another issue. Any chance we can add a UI test for this fix?

kriboogh’s picture

kriboogh commented
StatusFileSize
new migrate_tools-ui-limit-2924298-7.patch1.99 KB

I removed the exception stuff, and updated the patch file according to the documentation.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Issue tags: +Needs tests

Tagging for tests. Can we see an interdiff to that last patch?

kriboogh’s picture

kriboogh commented
StatusFileSize
new interdiff_4_7.txt3.25 KB

Added the inferdiff. Sorry no time to write the tests myself.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Issue tags: +Needs manual testing

I'll even accept manual testing. Anything.

karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented
Issue tags: -Needs manual testing

#7 worked for me with limits both under and over the batch size.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs work » Reviewed & tested by the community

Sounds like an RTBC to me.

  • heddn committed 9fc2977 on 8.x-4.x authored by kriboogh 
    Issue #2924298 by kriboogh, heddn, KarlShea: Add limit to Web UI...
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.