Needs work
Project:
Migrate Tools
Version:
6.1.x-dev
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 Nov 2017 at 11:32 UTC
Updated:
31 Dec 2025 at 17:37 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
kriboogh commentedAdded bulk execution.
Comment #3
heddnNeeds work also because needs tests.
Comment #4
mschudders commentedCorrect patch for missing "MigrateBatchMessage" class.
Comment #5
mschudders commentedCorrect patch #1
Comment #6
mschudders commentedComment #7
kriboogh commentedUpdated patch for latest 4.x
Comment #8
kriboogh commentedPatch was not deploying, corrected.
Comment #9
kriboogh commentedPatch updated
Comment #10
trebormc#9 Works fine
Thanks.
I love the Drupal community just for things like this
Comment #11
heddnCould use a re-roll. And it isn't passing phpcs.
Comment #12
sokru commentedReroll, some coding standards and few comments below:
in src/Controller/MigrationListBuilder.php #72
LoggerChannelInterface has removed from 8.x-4-x, replaced with LoggerInterface.
in src/Controller/MigrationListBuilder.php #309
added missing documentation.
in src/MigrateBatchExecutable.php #179
currently in latest 8.x-4.x:
`$operations = array_merge($operations, $this->batchOperations($required_migrations, $operation, [`after the patch:
`$operations += static::batchOperations($required_migrations, $operation, [`Comment #13
rpayanmComment #14
heddnThere's some code standard failures (see https://www.drupal.org/pift-ci-job/1391870) and we should have some tests.
Comment #15
rpayanmComment #16
ajitsComment #17
kriboogh commentedRe-roll against 8x4.3
Comment #18
kriboogh commentedMigrateBatchMessage went missing in the last re-roll.
Comment #19
kriboogh commentedFixed patch (wasn't applying correctly
Comment #20
heddnStill doesn't apply cleanly.
Comment #21
kriboogh commentedMaybe now...
Comment #22
heddnStill needs tests, but at least here are the PHPCS fixes.
Comment #23
bserem commentedPatch in #22 applies. There are some things that I'd like to express that might or might not be relevant to the task at hand.
tl;dr: It works. See comment-24.
On this custom migration module:
I get this drush output, after
drush mim --group users:On the UI I see the execute all button, and it actually works and imports stuff. But there is no option to select which migration to run nor does it identify migration groups:

The YML source of the migration file is:
I am gonna put this back to needs work until further clarification of what is to be expected on the UI.
I would expect to see a list of migrations and (maybe) some checkboxes on which to execute.
Feel free to bump it back to review if I missed the point here.
All in all, it works nicely! Nice work.
Comment #24
bserem commentedHmmm... it turns out I am facing a different UI issue here. The UI will not pick migrations that do not go into the config system.
So, the
migrations/users.ymlfolder structure works fine with migrate (and updates with a plain drush cr) but it will not list migrations to the migrate_tools UI.For migrations to be displayed in the UI they must go into
config/install/migrate_plus.migration.users.ymlBumping it back to "needs review" myself.
Comment #25
heddnI'm looking to roll a 4.5 migrate tools release in the next few days. This would be nice to see land with it, but if it doesn't, that's fine too. I'm not sure how much is left to do here, as there are still test failures.
Comment #26
bserem commentedI'll test this tomorrow, I just changed all my migrations from "migration" to "configuration" so as to test properly.
Comment #27
bserem commentedUI wise the patch works as long as migrations come from config like described above.
The execute all button works when importing but you can't rollback with it.
Comment #28
heddnStill seems to need work because tests are failing.
Comment #29
heddnAnd seems to need a re-roll.
Comment #30
ravi.shankar commentedHere I have added re-roll of patch #22.
Comment #31
bserem commentedPatch #30 works as expected (the button is there and it does the job) on Drupal 8.8
Comment #32
sorlov commentedStill cannot do rollback from UI with this patch
Comment #33
YurkinPark commentedwill provide more batch tests
Comment #35
YurkinPark commentedComment #36
YurkinPark commentedAdded tests for current feature
Comment #37
YurkinPark commentedMinor comment changes
Comment #38
heddnThis is a BC break. Folks extend the executable in their own code. Making this modification will break them.
And there seems to be a lot of work on batch and batch rollback in here. Can we split those pieces off into their own dedicated issues?
Comment #39
sorlov commentedMade next changes:
Comment #40
heddnThis is a really hard to review issue in its current state. Are there smaller parts we can break up that are more closely scoped that will get us close to VBO support? Then a final form facing issue that just wires into the API?
Plus, NW for PHPCS.
Comment #41
sorlov commentedI think, only part that can be separated - making batch rollback for MigrationExecuteForm
But actually, I don't see any difficulties with current patch.
We have only 3 main parts here:
1. Add ability to select migrations and run operations for them in MigrationListBuilder
2. Update MigrateBatchExecutable to run batch operations for multiple migrations
3. Update MigrationExecuteForm to use the same way as for MigrationListBuilder
Comment #42
sorlov commentedReroll for patch from #39
Comment #43
tonytheferg commentedSlick feature, but I normally see 2-3 pages of migrations, and with the patch applied I only see the first page?
Comment #44
fskreuz commentedRerolled patch #42 against 5.x
Comment #45
james.williamsThis needs another re-roll since #3012731: Provide status message when migration is reverted/stopped/reset via the user interface was completed.
Comment #46
larvymortera commentedRerolled patch #44 against 6.0.x
Comment #50
aron novakLet's see if tests do pass.
Comment #51
aron novakComment #52
aron novakThe patch was applied to latest dev as a MR, also I added test coverage.
Comment #53
heddnPosted some feedback on the MR.
Comment #54
heddn