Quick edit error when rendering commerce product variation fields injected into the commerce_product template

Problem/Motivation

When rendering injected field from the commerce variation entity into the commerce product template, we’ve got warning in the console about Quick Edit

Quick Edit could not associate the rendered entity field markup (with [data-quickedit-field-id="commerce_product_variation/4361/price/fr/full"]) with the corresponding rendered entity markup: no parent DOM node found with [data-quickedit-entity-id="commerce_product_variation/4361"]. This is typically caused by the theme's template for this entity type forgetting to print the attributes.

For example, the price field is rendered from the commerce_product.html.twig template as below

{# Sidebar #}
<div class="product-sidebar col-xs-12 col-sm-4 col-md-3 pull-right">
  {{ product.variation_price }}
</div>

This error make sens as the fields are not rendered into the commerce_product_variation template, and so Quick edit didn't find the corresponding data-quickedit-entity-id for the commerce product variation

Proposed resolution

Add a wrapper around the field injected width the data-quickedit-entity-id ? But then we could have several and similar data-quickedit-entity-id attributes in the DOM.

Don't support the quick edit feature on theses fields injected into the commerce product template ? And so remove this attribute for any field injected ?

It seems that injected field is a scenario not supported by Quick Edit module (because injected field are not rendered in their entity's view mode)

In quickedit module we can read line 140

  // Quick Edit module only supports view modes, not dynamically defined
  // "display options" (which \Drupal\Core\Field\FieldItemListInterface::view()
  // always names the "_custom" view mode).
  // @see \Drupal\Core\Field\FieldItemListInterface::view()
  // @see https://www.drupal.org/node/2120335
  if ($element['#view_mode'] === '_custom') {
    return;
  }

So, we could prevent Quick edit to add its attributes on the injected fields

Remaining tasks

- Create a patch

User interface changes

None

API changes

None

Data model changes

None