No store when creating register

1. +++ b/src/Form/RegisterForm.php
   @@ -14,6 +16,18 @@ class RegisterForm extends ContentEntityForm {
      public function form(array $form, FormStateInterface $form_state) {
   +    // Skip building the form if there are no available stores.
   +    $stores = Store::loadMultiple();
   

   I think in an ideal world we'd do this a bit differently. I think we should deny access to register creation if there are no stores. And on admin/commerce/config/pos/registers if there are no stores then we should have help text to explain that in order to add a register you need to add a store. However that's quite a bit of work for not a huge amount of gain. We could just use drupal_set_message() and do throw new AccessDeniedHttpException(); as a quick work around. That would also remove the need for overriding the actions method.

2. +++ b/src/Form/RegisterForm.php
   @@ -14,6 +16,18 @@ class RegisterForm extends ContentEntityForm {
   +      $link = Link::createFromRoute('Add a new store.', 'entity.commerce_store.add_page');
   +      $form['warning'] = [
   +        '#markup' => $this->t("Registers can't be created until a store has been added. @link", ['@link' => $link->toString()]),
   +      ];
   

   See #2923176-5: No Register helper text for a comment about the translatability of something like this.

Rerolled patch, as it wasn't applying on my local. RegisterForm.php had different code.

Please review, changes made as suggested in #4.

Patch tested and works as described above. But do we need to show access denied? Because it sounds like a permission issue.

Assigning myself.

I am totally agreeing with #8 and #9, So removing throw new AccessDeniedHttpException(); .

IMHO, drupal_set_message() automatically themed. Alex also mentions that in comments on the other issue.

Reviewing the patch.

1. +++ b/src/Form/RegisterForm.php
   @@ -14,11 +17,30 @@ class RegisterForm extends ContentEntityForm {
   +    if ($form_state->get('no_stores')) {
   

   This is not working.

2. +++ b/src/Form/RegisterForm.php
   @@ -14,11 +17,30 @@ class RegisterForm extends ContentEntityForm {
   +    $actions = parent::actions($form, $form_state);
   

   Better do this return parent::actions(), instead of creating new variable.

Found these problems. I am going to work on them.

+++ b/src/Form/RegisterForm.php
@@ -2,8 +2,11 @@
+use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;

Unnecessary use statement also found.

1. +++ b/src/Form/RegisterForm.php
   @@ -14,11 +16,34 @@ class RegisterForm extends ContentEntityForm {
   +    $form = parent::form($form, $form_state);
   

   We can do return parent::form() here.

2. +++ b/src/Form/RegisterForm.php
   @@ -14,11 +16,34 @@ class RegisterForm extends ContentEntityForm {
   +    ¶
   

   Whitespace.

Hi,

Patch updated as per #18. Please review.