Closed (fixed)
Project:
Bootstrap Library
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
11 Nov 2017 at 23:33 UTC
Updated:
3 Feb 2020 at 20:28 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
kay_v commentedpatch attached
Comment #3
mfrosch commentedHad the same issue - patch worked for me - please apply or check for "dist" if files are does not exist.
Thanks
Comment #4
frobI think this is avoiding the larger problem with this module. There are two download links on the getbootstrap download page.
Source
https://github.com/twbs/bootstrap/archive/v4.1.0.zip
Dist
https://github.com/twbs/bootstrap/releases/download/v4.1.0/bootstrap-4.1...
The official composer package downloads the source version. However, depending on your sites configuration that could put the library in a directory that is inaccessible to the browser.
Proposed Solution:
Change the options for selecting what version to use from dev/production (minified/non-minified) to source/dist. At the very least we should have documentation telling people to only download the dist version from getbootstrap.
For anyone finding this on google. To make this work with composer and not have to patch the module put this into your composer.json under repositories:
Comment #5
frobHere is a patch that adds the composer source version as an option on the dropdown. It isn't a great solution, but it is a non-destructive/backwards-compatible solution.
Comment #6
hatuhay commentedComment #7
hatuhay commentedComment #8
frob@hatuhay, I am confused. How is this fixed?
Comment #9
hatuhay commentedA composer.json file was added and the local composer location either
Comment #11
efpapado commentedI don't understand this. Could you be more specific?
Comment #12
justinmello32 commentedI'm a little confused on the composer.json addition but I know the patch was able to help.
Just needed to point to bootstrap/dist/css/ and bootstrap/dist/js/ instead of just bootstrap/css and bootstrap/js
Thanks for the help on this, library is now working locally! :)
Comment #13
drupalfan2 commentedHow will this be solved in next release version 8.x-1.12?
There is no reason why we should not be able to download the source files version of bootstrap 4. Then a subfolder /dist/ is needed.
Of course the compiled version could also be downloaded, then no subfolder /dist/ is needed to work.
Comment #14
ressaWhat is the status here? It seems unresolved ...
Comment #15
frobLooks like my patch from #4 was committed which added a new option for the dropdown. I don't know if there is still an issue here or if another solution needs to be made, but I suggest opening a new issue and linking here if anyone has further questions.