Currently this module holds metadata-info for XLS(X) Excel files.

According to a @todo in the source this should be moved to a plugin, for Excel files this is xls_serialization (https://www.drupal.org/project/xls_serialization).

In related issue (https://www.drupal.org/project/issues/xls_serialization/2922770) this module gets it's own Views Style and Display plugins, which means the metadata can move to there.
The patch in that issue does so.

As soon as the related issue is committed, running the patch attached here removes the Excel metadata functionality from this module.

CommentFileSizeAuthor
#10 views_data_export-move_xls_options_to_xls_serialization_module-2922777-10.patch3.46 KBspokje
#4 views_data_export-move_xls_options_to_xls_serialization_module-2922777-4.patch4.21 KBspokje

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Related issues: +#2922770: Style Worksheet header (Bold, italic, Background color)
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new views_data_export-move_xls_options_to_xls_serialization_module-2922777-4.patch4.21 KB
spokje’s picture

spokje
Primary language Dutch
commented

Coding standards message fixed in issue https://www.drupal.org/node/2922153

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
Status: Active » Needs review
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

There's a documentation issue for this: #2932133: Document 'Excel Serialization' XLS sub-module on project page, which we can get to once this gets in.

Webbeh’s picture

Webbeh
he/him/his
Location Georgia, USA
commented
Status: Needs review » Reviewed & tested by the community

As soon as the related issue is committed, running the patch attached here removes the Excel metadata functionality from this module.

As this has happened, moving this to RTBC for #2932133: Document 'Excel Serialization' XLS sub-module on project page.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Reviewed & tested by the community » Needs work

Unfortunately this patch no longer applies.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review
StatusFileSize
new views_data_export-move_xls_options_to_xls_serialization_module-2922777-10.patch3.46 KB

Rrrrrrrrre-roll :)

  • jhedstrom committed 4b9ceaf on 8.x-1.x authored by Spokje 
    Issue #2922777 by Spokje: Move xls(x) options to xls_serialization...
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.