Branch 8.x-1.x-dev has some coding standards messages.

CommentFileSizeAuthor
#20 fix.png21.88 KBmanish-31
#19 Screenshot from 2023-10-10 16-40-34.png21.59 KBdiwakar07
#16 Screenshot from 2023-07-20 17-14-26.png146.48 KBroshni27
#14 views_data_export_fix_coding_standard_messages-2922153-14.patch3.33 KBphjou
#11 views_data_export_fix_coding_standard_messages-2922153-11.patch5.14 KBsivaprasadc
#11 interdiff-2922153-6-11.txt1.44 KBsivaprasadc
#9 csv-error.png96.43 KBsarguna raj m
#7 interdiff.txt483 bytesspokje
#6 views_data_export_fix_coding_standard_messages-2922153-6.patch3.8 KBspokje
#3 views_data_export_fix_coding_standard_messages-2922153-3.patch3.33 KBspokje
#2 views_data_export_fix_coding_standard_messages-2922153-2.patch3.11 KBspokje

Issue fork views_data_export-2922153

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new views_data_export_fix_coding_standard_messages-2922153-2.patch3.11 KB

Attached patch should fix all coding standard messages.

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new views_data_export_fix_coding_standard_messages-2922153-3.patch3.33 KB

*sigh*

Always one that escapes...

Retry

spokje’s picture

spokje
Primary language Dutch
commented
spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
Status: Active » Needs review
spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new views_data_export_fix_coding_standard_messages-2922153-6.patch3.8 KB

Me and Testbot both missed one.

Fixed in attached patch.

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new interdiff.txt483 bytes
sarguna raj m’s picture

sarguna raj m commented
Assigned: Unassigned » sarguna raj m
sarguna raj m’s picture

sarguna raj m commented
Assigned: sarguna raj m » Unassigned
StatusFileSize
new csv-error.png96.43 KB

Hi Spokje,

When I tried to enable the Views data export module the dependence module CSV Serialization requires the League\Csv library. I tried via composer to install it but unable to resolve.

sivaprasadc’s picture

sivaprasadc commented
Assigned: Unassigned » sivaprasadc
Status: Needs review » Needs work
sivaprasadc’s picture

sivaprasadc commented
Assigned: sivaprasadc » Unassigned
Status: Needs work » Needs review
StatusFileSize
new interdiff-2922153-6-11.txt1.44 KB
new views_data_export_fix_coding_standard_messages-2922153-11.patch5.14 KB

@Spokje

Thanks for the patch. Still few more issues are there. I have created the interdiff and patch files. Kindly review it.

Thanks

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community

@sarguna raj M

That's a csv_serialization issue/composer issue on your setup, a lot of solutions are discussed here:
https://www.drupal.org/project/issues/csv_serialization?text=League%5CCs...

@Sivaprasad C:

Well spotted and it works for me on a fresh install of Drupal 8.4.4 so: RTBC

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Reviewed & tested by the community » Needs work

Unfortunately these no longer apply.

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
StatusFileSize
new views_data_export_fix_coding_standard_messages-2922153-14.patch3.33 KB

Since the patch was not applying anymore, I just rerolled the patch.

Half of the errors have been fixed and one or two new ones have been introduced.

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
Status: Needs work » Needs review
roshni27’s picture

roshni27 commented
Status: Needs review » Needs work
StatusFileSize
new Screenshot from 2023-07-20 17-14-26.png146.48 KB

These no longer apply before #14 thats why I have applied patch #14 in 8.x.1.x.
But it does not applied cleanly , share the screenshot.

Diwakar07 made their first commit to this issue’s fork.

Diwakar07 opened merge request !29

diwakar07’s picture

diwakar07 commented
Status: Needs work » Needs review
StatusFileSize
new Screenshot from 2023-10-10 16-40-34.png21.59 KB

I have fixed the errors reported by phpcs.
Please review.
Attached is the screenshot of the file extensions checked by phpcs.

manish-31’s picture

manish-31 commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new fix.png21.88 KB

I have applied the MR patch and tested PHPCS warnings. No warnings/errors on PHPCS scan.

Attaching screenshot and marking RTBC. Thanks!

Steven Jones made their first commit to this issue’s fork.

steven jones’s picture

steven jones commented
Status: Reviewed & tested by the community » Fixed

Thanks everyone for the work!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.