A module for inlining a critical CSS file into a page's HTML head, loading non-critical CSS asynchronously using W3C Spec's preload.

How it works

  1. This module looks for a css file inside your theme directory. This css filename should match any of:
    • bundle type (i.e., "article.css")
    • entity id (i.e., "123.css")
    • url (i.e., "my-article.css")
  2. If any of the above paths is found, this module loads the CSS file contents inside a <style> tag placed in the HTML head.
  3. Any other CSS file used in HTML head is loaded using preload. For browsers not supporting this preload feature, a polyfill is provided.

PROJECT URL: https://www.drupal.org/project/critical_css

GIT CLONE COMMAND: git clone --branch 8.x-1.x https://git.drupal.org/project/critical_css.git

Manual reviews of other projects

https://www.drupal.org/node/2905093#comment-12327461
https://www.drupal.org/node/2908856#comment-12327445
https://www.drupal.org/node/2917316#comment-12327459

CommentFileSizeAuthor
#8 critical_css_phpcs_errors.txt17.04 KBsaivaishnavijupudi
#6 2920677#comment-12459491_pareview.txt4.21 KBjfs.csantos

Comments

asilgag created an issue. See original summary.

PA robot’s picture

PA robot commented

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

albertosilva’s picture

albertosilva
Primary language Basque
Location Basque Country
commented

Changed: I'm volunteering my own time

albertosilva’s picture

albertosilva
Primary language Basque
Location Basque Country
commented
Issue summary: View changes
Issue tags: +PAreview: review bonus
jfs.csantos’s picture

jfs.csantos commented

Hi there @asilgag

Here is my bit of review of the module, hope it helps:

Automated Review

Pareview.sh reported a few things which you can see in the attached report file, nothing major, only linting.

Manual Review

  • Not sure if automatically getting a release from a git repo in the install hook is recommended. Might want to look into that, there's no harm in getting the dependencies manually.
  • Why not have a visible link to the module configuration? If you use, for example, system.admin_config_development as a link you can have it there in the Development menu. (just a suggestion anyway).
jfs.csantos’s picture

jfs.csantos commented
StatusFileSize
new 2920677#comment-12459491_pareview.txt4.21 KB

Forgot the file :)

mario steinitz’s picture

mario steinitz
Location Hong Kong Central
commented
Status: Needs review » Needs work

You also forgot setting the issue to "Needs work". Done.

saivaishnavijupudi’s picture

saivaishnavijupudi commented
StatusFileSize
new critical_css_phpcs_errors.txt17.04 KB

i found the above issues

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Reviewed & tested by the community

PAReview still reports some issues (https://pareview.sh/pareview/https-git.drupal.org-project-critical_css.g...), but I didn't find any security issues.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.