Install fresh Drupal once you complete the installation successfully, on front page there is link which points to User Guide to start building your site. Currently when we click on link it's getting open in same window. It will be good if we will open that link in new tab.
When Drupal is freshly installed, The main page where the link for the user guide is should open. When link for user guide is clicked it should open a a user friendly way which allows user to glance between tabs.
This will provide convenience for the user as they can flick between tabs which helps them work more productively
Is now in 'needs review' stage by the Drupal test bot. All documentation and information are attached
user guide" link is clicked on it should open in a new tab. This increases the functionally of the user interface
Install fresh Drupal once you complete the installation successfully, on front page there is link which points to User Guide to start building your site. Currently when we click on link it's getting open in same window. It will be good if we will open that link in new tab
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | user_guide_link.png | 109.72 KB | dev.patrick |
| #11 | user_guide_link_on-2920172-11.patch | 2.07 KB | sushantpaste |
| #10 | user_guide_link_on-2920172-10.patch | 867 bytes | sushantpaste |
| #7 | user_guide_link_on-2920172-7.patch | 867 bytes | sushantpaste |
| #4 | installation-complete-userguide-2920172-4.patch | 867 bytes | dev.patrick |
Comments
Comment #2
sushantpasteComment #3
cilefen commentedCould you retitle the issue to be more specific?
Comment #4
dev.patrick commentedThis should do the needful, User Guide link is added to 8.5.x prior to this I don't see traces of it, so patch may fail to 8.4.x or below.
Comment #5
dev.patrick commentedComment #7
sushantpasteUpdated issue title and added patch.
Comment #8
sushantpasteComment #10
sushantpasteAdded fix for Test. New patch added.
Comment #11
sushantpastePlease ignore previous patch sorry for that by mistake added old patch. Here is the consolidated patch.
Comment #12
dev.patrick commentedPatch applied cleanly, with fresh installation User Guide link is opening in new tab. Attaching screenshot
Comment #13
xjmThanks for the patch and testing!
I'm not sure about this change. We don't usually use
target="_blank"for external links. I also thought the best practice nowadays was no longer to hardcode link targets, but to allow the user to choose whether to open content in a new window or not.We have a handful places in core that use
target="_blank", a couple in the installer and a couple in the datetime module, but the vast majority of our external links to references do not use it.Tagging for a usability review.
Comment #15
dev.patrick commented@xjm , tagging to usability review would be correct this time, found dangling discussion here : https://www.drupal.org/node/2652272
Comment #17
Ashreen Kaur commentedComment #18
Ashreen Kaur commentedComment #19
Ashreen Kaur commentedComment #20
Ashreen Kaur commentedComment #21
yoroy commentedI'm in favor of opening in a new window. I don't think it's a good look that the first link we offer after succesful installation is taking you away from your succesful installation.
Comment #22
dev.patrick commentedAny other views on it?
Comment #23
yoroy commentedNo :) Lets do this!
Comment #24
dev.patrick commentedPutting it on RTBC and see if still someone come up for with suggestion on it. Else we are good.
Comment #25
larowlanCrediting @Ashreen Kaur for significant updates to the issue summary, @xjm for a committer review and @yoroy for a usability review.
Comment #27
larowlanCommitted as 18bba35 and pushed to 8.5.x
Thanks for your contributions.
Great work on the issue summary @Ashreen Kaur
Congatulations on your first core commit credits @Ashreen Kaur and @dev.patrick!
Comment #28
yoroy commentedYay, well done!
Comment #30
dawehnerRetrotagging