[D8] OneScreen

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi @Alex_Gred
I installed your theme and checked the code with a code sniffer. The code sniffer did not give any comments.
Great job.

Hello @Alex_Gred,

I'm working on your OneScreen theme and found the following issues on a mobile phone:

1) The sidebar doesn't show up.
2) The middle and the right columns in the footer don't show up.

This is the case in your demo site as well.
Hope to see fixes very soon.

Thank you!!

Nice looking theme! Here is my review:

Automated Review

https://pareview.sh/node/2875

Looks good! No comments.

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

No: Does not follow the guidelines for 3rd party assets/code. It looks like the theme includes a few external libraries / features: jquery.flexslider.js, jquery.viewportchecker.js, bootstrap.js. Please review the link above for guidelines for 3rd party assets/code. You might consider integrating with the flexslider module as an optional feature by checking if module exists. You might consider using a CDN for bootstrap. Or you might want to include instructions in the README.md for users to download and install the required 3rd party assets.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

A couple minor things that I noticed in the code.

1. In theme-settings.php I think hook_form_FORM_ID_alter() should be hook_form_system_theme_settings_alter() and &$form_state should be \Drupal\Core\Form\FormStateInterface $form_state
2. In onescreen.theme I think Implements template_preprocess_breadcrumb() should also be Implements hook_preprocess_HOOK().

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

This review uses the Project Application Review Template.

Automated Review

Automated review checked at https://pareview.sh/node/2875. No issues.

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[Yes: Does not cause] module duplication and/or fragmentation.

Master Branch

[Yes: Follows] the guidelines for master branch.

Licensing

Not such things found.

3rd party assets/code

Not any third party API using.

README.txt/README.md

[Yes: Follows] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements.]

Coding style & Drupal API usage

good to go.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Hi @Alex_Gred,

I have installed your theme and tested, it's working fine. Haven't found any issues. Thanks for the theme.

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.