When entering a cash amount on the payment page, you can add infinite decimals, we should not even allow this, instead of just dealing with it on the backend. The fraction digit setting in currency should be used for the allowed number of decimal places.

CommentFileSizeAuthor
#9 2916647-9.patch2.91 KBsmccabe
#6 2017-12-16_012131.png13.28 KBjnrfred
#5 2916647-5.patch2.98 KBsorabh.v6

Comments

smccabe created an issue. See original summary.

sorabh.v6’s picture

sorabh.v6
He/His
Primary language Hindi
commented
Assigned: Unassigned » sorabh.v6

Working on it.

sorabh.v6’s picture

sorabh.v6
He/His
Primary language Hindi
commented
Issue summary: View changes
sorabh.v6’s picture

sorabh.v6
He/His
Primary language Hindi
commented
sorabh.v6’s picture

sorabh.v6
He/His
Primary language Hindi
commented
Assigned: sorabh.v6 » Unassigned
Status: Active » Needs review
StatusFileSize
new 2916647-5.patch2.98 KB

Patch for limiting keypad amount is limited to fraction digit settings in currency. Test need to be updated. Will post them soon.

jnrfred’s picture

jnrfred commented
StatusFileSize
new 2017-12-16_012131.png13.28 KB

Can confirm patch works. see attached

Status: Needs review » Needs work

The last submitted patch, 5: 2916647-5.patch, failed testing. View results

smccabe’s picture

smccabe commented

I did a bunch of work to cleanup the keypad stuff and get the tests passing, so this patch just needs a quick re-roll and it should be good to go.

smccabe’s picture

smccabe commented
StatusFileSize
new 2916647-9.patch2.91 KB

Re-rolled patch

  • smccabe committed 0c47590 on 8.x-2.x 
    Issue #2916647 by smccabe, sorabh.v6, jnrfred: Cash amount should be...
deepakaryan1988’s picture

deepakaryan1988
Primary language Hindi
commented
Assigned: Unassigned » deepakaryan1988
subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented

I think we can close this issue.

deepakaryan1988’s picture

deepakaryan1988
Primary language Hindi
commented
Assigned: deepakaryan1988 » Unassigned

I was checking the issue. But I think, we can close this issue.
I am leaving this to @smccabe!!

smccabe’s picture

smccabe commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.