Maybe I'm missing something, but if the Inline Form Errors module is stable as of 8.4.0 and if its goal is to have "improved usability and accessibility" when there are errors displayed on a form, Drupal turn it on by default once it's ready.

Postponed on

#2856950: Add a possibility to disable inline form errors for a complete form
#2848507: Indicate that grouping elements have child element errors for ux and a11y

CommentFileSizeAuthor
#5 Screen Shot 2017-10-17 at 4.01.17 PM.png90.71 KBmgifford
#5 Screen Shot 2017-10-17 at 4.00.31 PM.png296.02 KBmgifford
#2 inline-form-errors-2915899-2.patch346 bytesDavid_Rothstein
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

David_Rothstein created an issue. See original summary.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein as a volunteer commented
Status: Active » Needs review
FileSize
inline-form-errors-2915899-2.patch346 bytes

Here is a patch.

dmsmidt’s picture

dmsmidt
he/him
Primary language Dutch
Location Amsterdam 🇳🇱🇪🇺
CreditAttribution: dmsmidt commented

Certainly a plus one from me! I would even like IFE during install ;-)

dmsmidt’s picture

dmsmidt
he/him
Primary language Dutch
Location Amsterdam 🇳🇱🇪🇺
CreditAttribution: dmsmidt commented
Issue tags: +Accessibility, +Usability
mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford at OpenConcept Consulting Inc. commented
FileSize
Screen Shot 2017-10-17 at 4.00.31 PM.png296.02 KB
Screen Shot 2017-10-17 at 4.01.17 PM.png90.71 KB

This would be great to get into Core. I've tried this out on SimplyTest.me and it worked fine. Attached a couple screenshots so that there are some visuals to go along with the patch.

+1

Who else should look at it before it is RTBC'd?

dmsmidt’s picture

dmsmidt
he/him
Primary language Dutch
Location Amsterdam 🇳🇱🇪🇺
CreditAttribution: dmsmidt commented
Status: Needs review » Reviewed & tested by the community

Don't know Mike.

This is as straight forward as they get.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue tags: +Needs product manager review

Nice idea. This would be good for the product team to review and sign off on.

Thanks folks!

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Reviewed & tested by the community » Needs work

@xjm pointed out that while #2504847: [meta] Roadmap for stabilizing Inline Form Errors module (IFE) is closed, there are some issues that were originally a requirement but not actually resolved. Particularly #2856950: Add a possibility to disable inline form errors for a complete form and even more so #2848507: Indicate that grouping elements have child element errors for ux and a11y. Without the later issue, fieldsets are quite broken. We can use this issue to track the remaining work needed to enable in the standard profile as well. Leaving the product manager tag on since other product managers could provide feedback on this well :)

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue summary: View changes
Status: Needs work » Postponed
Issue tags: -Needs product manager review

Let's do this -- add those two issues to the summary and postone this one until they're ready?

Edit: Oops, missed the bit in #8 about leaving the tag on. But since we know those two issues are outstanding issues with having IFE as the default, let's have product manager review once they're fixed so that they'll be reviewing the final thing. :)

andrewmacpherson’s picture

andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer and at Annertech commented
Related issues: +#2504847: [meta] Roadmap for stabilizing Inline Form Errors module (IFE)

These two issues look reasonable postponement criteria. They are the only two outstanding should-haves from #2504847: [meta] Roadmap for stabilizing Inline Form Errors module (IFE).

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Title: Enable the Inline Form Errors module in the Standard install profile » [PP-1] Enable the Inline Form Errors module in the Standard install profile

A year has passed. What's the status of this?

#2856950: Add a possibility to disable inline form errors for a complete form landed. #2848507: Indicate that grouping elements have child element errors for ux and a11y is still in progress, and is blocked on review..

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel at Lullabot commented

+1 on this. This came up in the Olivero issue queue #3154357: Enable Inline Form Errors module in install profile process.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.