On table with drag&drop when dragging with the keyboard arrow keys there should be a visual feedback when moving to a place where the current element is not possible to be placed at.

Example:
When going left like in that image below you don't get any feedback about that this move was not allowed. Instead of just doing nothing there should to be at least something to be happening, like showing an information that that move was not possible.

visual feedback needed

A first approach would be to show a red Icon, instead of the black one, for about 1 second. Then switching back to the black one.

visual feedback example

Members fund testing for the Drupal project. Drupal Association Learn more

Comments

kwoxer created an issue. See original summary.

BarisW’s picture

Priority: Major » Normal
Status: Needs review » Active
Issue tags: -Triaged for D8 major current state, -Triaged D8 major, -needs accessibility review +Needs issue summary update

Hey kwoxer,

Need review is only for when there is an actual patch to review. Let's put this in the default state.
Also, this isn't a major issue IMHO. Lastly, tags like 'needs accessibility review' are to be added when there is something for the accessibility team to test.

geophysicist’s picture

BarisW’s picture

Status: Active » Needs review
kwoxer’s picture

Category: Bug report » Feature request
Issue summary: View changes
Issue tags: -Needs issue summary update
kwoxer’s picture

Issue summary: View changes
kwoxer’s picture

FileSize
13.52 KB
kwoxer’s picture

Issue summary: View changes
BarisW’s picture

Status: Needs review » Needs work

Thanks for the patch. Great work!

A few things:

  • For screenreaders, we would also need a way to let people know about the error. An image alone would not be enough. Can we add a hidden span with an error message?
  • Javascript changes should be made in the es6 files, not directly in the js files. See Drupal core now using ES6 for javascript development.
  • And would it be possible to add a test for this?
kwoxer’s picture

FileSize
9.8 KB

Thank you very much @geophysicist.

I tested your Patch together with https://www.drupal.org/files/issues/2725259-31.patch and it works properly.

Here an image:

But as @BarisW said, screen readers are missing.

geophysicist’s picture

Hey
I will add screen readers, move code to es6 file as soon as possible (3-5 days)
Also will try to add tests.

kwoxer’s picture

@geophysicist how is it going with the table drag, did you found some time already? :)

geophysicist’s picture

@kwoxer not yet. Sorry about that. But i'm working in the US this month and i'll try to find some time to finish this task.
P.S. my docker machine "vienna2017" is still running.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.