This module is for soft deletion of a node. It is role based authentication module to delete a node as temporary or permanently.

INTRODUCTION
This module is for soft deletion of a node. There are some other modules for node soft deletion. But in 'Soft Deletion' there is a permission access to control content :

  • Access to put content into recycle-bin.
  • Access to restore content from recycle-bin.
  • Access to show soft deleted content.

INSTALLATION

    Download and Enable Soft Deletion module. Go to permissions and grant the permission to a specific role.
  • Requirements: Administration views

How To Use

    Any user/role except administrator, who has permission to put content into recycle-bin can use delete link for soft deletion of content. (Go to /admin/content -> select 'delete' for soft delete).
  • Click on menu : Recycle-Bin having url: /recycle-content to view Recycle-bin.
  • Click on Restore link to get back the content from recycle-bin.

Project page: https://www.drupal.org/node/2910439
Sandbox page: https://www.drupal.org/sandbox/parashram/2907523

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/Parashram/2907523.git
soft_deletion

Similar Modules
Entity Soft Delete : https://www.drupal.org/project/entity_soft_delete
Soft delete : https://www.drupal.org/project/soft_delete

CommentFileSizeAuthor
#10 2017-09-22_1514.png4.81 KBprajaankit
soft_deletion.tar_.gz15.59 KBparashram
soft_deletion.zip26.52 KBparashram

Comments

Parashram created an issue. See original summary.

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

Git clone command for the sandbox is missing in the issue summary, please add it.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

parashram’s picture

parashram commented
Title: Soft Deletion » [D7] Soft Deletion
Issue summary: View changes
parashram’s picture

parashram commented
Status: Needs work » Needs review

git clone command has been added.

parashram’s picture

parashram commented
Issue summary: View changes
parashram’s picture

parashram commented
Issue summary: View changes
parashram’s picture

parashram commented
Priority: Normal » Critical
parashram’s picture

parashram commented
parashram’s picture

parashram commented
prajaankit’s picture

prajaankit commented
StatusFileSize
new 2017-09-22_1514.png4.81 KB

HI @parash,

First thanks for this module , such a good module. neat and clean code.
No coding standard issue
I test it by (Drupalcs error). also
In this module no Drupalcs error.
I used this module with latest drupal 7.56 version, with both php5, php7
Every thing working fine you did the fantastic job.

Thanks
Ankit kumar

pankajsachdeva’s picture

pankajsachdeva commented

Hi @Parash,

My review:

Automated Review
No issues found.

Manual Review

Individual user account
[Yes: Follows] the guidelines for individual user accounts.

No duplication
[Yes] module duplication and/or fragmentation.
Please specify, how this module is different from existing soft deletion modules.

Master Branch
[Yes: Follows] the guidelines for master branch.

Licensing
[Yes: Follows] the licensing requirements.

3rd party assets/code
[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md
[Yes: Follows] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review
[Yes: Follows] the guidelines for project length and complexity.

Secure code
[Yes: Meets the security requirements.]

Coding style & Drupal API usage

  1. Please use the proper comments. You used 'Implements hook_foo' at various locations.
  2. Instead of creating 'soft_deletion_form' confirmation form, please use 'confirm_form()' function.
  3. Why this module has the dependency of 'Admin views' module. What if a site is not using this module. I think this module should work without this dependency.
  4. Please specify the similar modules which provides the functionality of soft delete on the project page as well as README.txt file. And how it is different from others. So users can select the module wisely.
pankajsachdeva’s picture

pankajsachdeva commented
Status: Needs review » Needs work
parashram’s picture

parashram commented

Hi @pankajsachdeva,

Thanks for commenting, here are my solution/comments for your review.

  • 3rd party assets/code

    • Comment: Follows.

  • Please specify, how this module is different from existing soft deletion modules.

    • Comment: Already mentioned in Introduction.

Coding style & Drupal API usage

  • Please use the proper comments. You used 'Implements hook_foo' at various locations.

    • Comment: Done.

  • Instead of creating 'soft_deletion_form' confirmation form, please use 'confirm_form()' function.

    • Comment: Done and thanks for such suggestion.

  • Why this module has the dependency of 'Admin views' module.

    • Comment: So that in future, we can implement some further bulk operations and some dynamic stuff. No need of rework will be there.

  • Please specify the similar modules which provides the functionality of soft delete

    • Comment: Done.

Thanks:
Parash Ram

parashram’s picture

parashram commented
Issue summary: View changes
Status: Needs work » Needs review
pankajsachdeva’s picture

pankajsachdeva commented

Hi @Parash,

I reviewed your module once again. Looking fine to me.

I also tested module functionality, everything looking good except Restore Confirmation form. I am getting WSoD. I think you forgot to add &$form_state in 'soft_deletion_confirm_form_submit'.

pankajsachdeva’s picture

pankajsachdeva commented
Status: Needs review » Needs work
parashram’s picture

parashram commented

Hi @pankajsachdeva,

&$form_state has been inserted to avoid WSoD in 'soft_deletion_confirm_form', 'soft_deletion_confirm_form_submit' function has already. Please have a look.

Thanks:
Parash Ram

parashram’s picture

parashram commented
Priority: Critical » Normal
Status: Needs work » Needs review
pankajsachdeva’s picture

pankajsachdeva commented

Everything looking good to me.

I am doing it RTBC.

Nice Work!!!

pankajsachdeva’s picture

pankajsachdeva commented
Status: Needs review » Reviewed & tested by the community
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.