CommentFileSizeAuthor
#6 coding_standard-2909028-6.patch12.29 KBdeaom
#3 create_unit_test-2909028-2.patch7.91 KBborisson_
#2 create_unit_test-2909028-2.patch8.78 KBborisson_

Comments

borisson_ created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Active » Needs review
StatusFileSize
new create_unit_test-2909028-2.patch8.78 KB
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
StatusFileSize
new create_unit_test-2909028-2.patch7.91 KB
maaty388’s picture

maaty388 commented
Status: Needs review » Needs work

I can't apply this patch!

Checking patch tests/src/Unit/CoderPluginManagerTest.php...
error: tests/src/Unit/CoderPluginManagerTest.php: No such file or directory
Checking patch tests/src/Unit/Plugin/coder/DefaultCoderTest.php...
error: tests/src/Unit/Plugin/coder/DefaultCoderTest.php: No such file or directory
Checking patch tests/src/Unit/Plugin/coder/TaxonomyTermCoderTest.php...
error: tests/src/Unit/Plugin/coder/TaxonomyTermCoderTest.php: No such file or directory
abramm’s picture

abramm
Primary language Ukrainian
Location Lutsk
commented
Related issues: +#2956977: Refactor FacetsPrettyPathsUrlProcessor to ease inheritance

Few coding standards issues could be fixed in #2956977.

deaom’s picture

deaom commented
Status: Needs work » Needs review
StatusFileSize
new coding_standard-2909028-6.patch12.29 KB

Fixed the coding standard.

upchuk’s picture

upchuk commented
Status: Needs review » Needs work

@borisson_

I added test coverage over most of the module functionality. Functional and Kernel tests. I don't think there is need to unit test the coder plugins anymore. However, if you want, you can reroll your patches (none apply anymore) and open a PR in the github repo. Meanwhile I will add the code sniffer for the coding standards and try to clean it up a bit.

Thanks!

upchuk’s picture

upchuk commented
Title: Create unit-test coverage and fix coding standards » Create unit-test coverage and fix coding standards + add PHP code sniffer

  • Upchuk committed 8f44bf7 on 8.x-1.x 
    Issue #2909028 by Upchuk, borisson_, DeaOm: Create unit-test coverage...
upchuk’s picture

upchuk commented
Status: Needs work » Fixed

I added PHPCS and fixed the reported coding standard issues. I tried to give you issue attribution but not sure why it shows up as unattributed :(

Closing this now, if you want to add unit tests, please open a PR. Thanks!

upchuk’s picture

upchuk commented
Status: Fixed » Closed (fixed)