Closed (fixed)
Project:
Thunder
Version:
8.x-2.7
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
14 Sep 2017 at 15:51 UTC
Updated:
28 Jun 2018 at 12:44 UTC
Jump to comment: Most recent
Problem/Motivation
Paragraphs development on the classic widget has stopped, all new developments are happening in the Experimental Widget. Thunder relies heavily on the Paragraph widget but is only running with the classic widget. To be able to get all the new and shiny features we have to migrate to the experimental widget as soon as it has some kind of release.
Proposed resolution
Move Thunder and thunder specific paragraphs handling to the experimental widget.
Pull request
For those who want to test, be aware this is very much WIP:
https://github.com/BurdaMagazinOrg/thunder-distribution/pull/413
Remaining tasks
Before we can move to the experimantel widget, the following issues shoul be fixed:
- #2919689: Collapse all button changes autocollapse behaviour
- #2925562: Collapse all for paragraphs with required fields
- #2877927: Show add widget between paragraphs
- #2956924: Entities get not referenced on node add when collapsing paragraph with inline entity form
- #2954298: Paragraphs actions are rendered as dropdown when there is only one option
- #2954283: Add confirmation when deleting paragraph items
Comments
Comment #2
miro_dietiker:-) To be honest, i guess i will close my eyes and just do a next release soon...
After all, it is and will still be experimental and that makes critical issues non-critical for an (experimental) release.
Classic is still stable...
We have some data loss problems with Drag & drop and we need more feedback. Also some parts should still are currently improved / refactored or should be. But progress is slow currently.
If a release helps to get more feedback and involve more people, we should do it ASAP.
Comment #3
daniel.bosenYay! Possible new Paragraphs release! :)
Comment #4
miro_dietikerHere it is (when it's generated). :-)
https://www.drupal.org/project/paragraphs/releases/8.x-1.2
Comment #5
mtodor commentedComment #6
miro_dietikerIt would be great to have here a list of all actionable items until Thunder can switch to the experimental Paragraphs widget.
And hopefully that widget will then soon no more be experimental? ;-)
Comment #7
chr.fritschAdded a list of remaining tasks
Comment #8
miro_dietikerCool. We discussed once that you want to hide the duplicate action via setting because it is not needed with add-in-between... Can't find that issue anymore?
Comment #9
miro_dietikerPutting these issues into references.
Comment #10
miro_dietikerI found the paragraphs split functionality and created an issue.
In fact this feature was discussed / requested multiple times already. So we should make it available outside Thunder as well.
Comment #11
miro_dietikerThe biggest blocker "Show add widget between paragraphs" has now actionable definitions and i'm available to support anyone who is ready to jump into its implementation.
The new (experimental) widget is currently quickly evolving and on its best way to become stable.
Comment #12
miro_dietikerWe have now widget features and it is a single click to disable "Edit all / Collapse all" actions if you don't like them.
The same functionality also allows us to simply disable the duplicate button.
Thus many items go away from the UI.
#2946441: Add setting to hide the duplicate button
Our default implementation if the "Add Paragraph above" button will be completed here soon:
#2946514: Add paragraph before button
Let's figure out if we can provide more common functionality for simple reuse.
Comment #13
daniel.bosenComment #14
daniel.bosenComment #15
daniel.bosenComment #18
daniel.bosenComment #20
daniel.bosenComment #21
miro_dietikerAwesome this is completed. Thanks for the great collaboration!