Collapse all button changes autocollapse behaviour

Yeah "Expand all" will disable the autocollapse again. This enable / disable of the autocollapse works in both directions.
It was designed for people who want this... ;-)

I guess we need an extra autocollapse setting that completely disables it - or create a new one that then triggers autocollapse behavior like now.

Autocollapse:

• Never
• Disabled until "collapse all"
• All

Open for better labels. :-)

I'll try to add this behavior proposed as it's proposed on #4, because with current behavior it's possible to start with "Autocollapse" enabled or disabled and it will change with "Collapse all" or "Edit all" action. So it's better to keep it separated instead of introducing 4th option to "Autocollapse" mode with: Enabled until "edit all".

And what do you think about using of Checkboxes instead of Dropdown buttons, since it's only true/false value in both cases?

I have adjusted implementation a bit. Since there is one case where behaviour is not so nice - fe. when you have autocollapse: yes and change autocollapse on collapse/edit all: no - then "Edit all" button should not expand all paragraphs (in general, it should be disabled). So what I have changed is, that "Change autocollapse behaviour" option works only for "Collapse all" button and "Edit all" button will always disable Autocollapse.

Patch with a proposal is attached to issue.

Just one more proposal (not related to this issue). Since this autocollapse enable/disable on collapse/edit all is a bit understandable and hidden behaviour, maybe we could show indicator if autocollapse is enabled or disabled. For example:

Corrected missing schema entry.

OK, convinced and revoking #3 - Sorry for the change of direction. :-)
We don't want to have a new setting for this small extra.

+++ b/src/Plugin/Field/FieldWidget/ParagraphsWidget.php
@@ -2357,10 +2370,12 @@ class ParagraphsWidget extends WidgetBase {
-    elseif ($submit['button']['#paragraphs_mode'] === 'closed') {

This is a bug, it should consider the "Autocollapse" setting and only enable autocollapse if it is enabled in the widget setting.

At the same time, if it's easy, let's hide the Autocollapse setting completely with states when the default state is open.

More ideas about collapse UX in follow-ups and opt-in only.

Working on this. :)

OK, it seems that we didn't need to update the autocollapse setting at all.

Tests added. :)

Fixing tests. :)

+++ b/src/Plugin/Field/FieldWidget/ParagraphsWidget.php
@@ -2365,14 +2372,6 @@ class ParagraphsWidget extends WidgetBase {
-    if ($submit['button']['#paragraphs_mode'] === 'edit') {
...
-    elseif ($submit['button']['#paragraphs_mode'] === 'closed') {

If you drop these, then expanding all is of a temporary effect if autocollapse is enabled in the widget.
It makes the autocollapse mode unusable for many cases.

If autocollapse is enabled in the widget settings, it is still needed to do these disable / enable switches.

Then what should it be the desired behavior?
If autocollapse enabled:
- Edit first paragraph, second is closed
- Edit second paragraph, first is closed
- Edit all, all open (disabling autocollapse) until...
- Collapse all, all closed (autcollapse enabled) until "Editing all"
?

Exactly. You just put the widget state changes above into an if() that checks if the widget configuration has autocollapse enabled.

I see, let's work on that then. :)

Maybe better. :)

1. +++ b/src/Plugin/Field/FieldWidget/ParagraphsWidget.php
   @@ -761,6 +768,7 @@ class ParagraphsWidget extends WidgetBase {
   +      $widget_state['autocollapse_default_setting'] = $this->getSetting('autocollapse');
   ...
   @@ -2417,12 +2425,13 @@ class ParagraphsWidget extends WidgetBase {
   

   Reads too much "setting" for me. :-) maybe just _default?

2. +++ b/src/Tests/Experimental/ParagraphsExperimentalHeaderActionsTest.php
   @@ -119,6 +119,28 @@ class ParagraphsExperimentalHeaderActionsTest extends ParagraphsExperimentalTest
   +    $this->assertNoRaw('class="paragraphs-collapsed-description">Second text');
   

   I would prefer to assert here (additionally) the editable field...

   BTW below we have some nice helper checkParagraphInMode() but it's a BrowserTest... We should convert and reuse the helper in some mid term follow-up.

Let's see. :)

1. +++ b/tests/src/Functional/ParagraphsExperimentalWidgetButtonsTest.php
   @@ -100,19 +101,19 @@ class ParagraphsExperimentalWidgetButtonsTest extends BrowserTestBase {
   -    // Open the first paragraph and then the second. Opening the second closes
   -    // the first.
   +    // Open the first paragraph and then the second. Opening the second doesn
   +    // not close the first.
   

   typo: doesn not

2. +++ b/tests/src/Functional/ParagraphsExperimentalWidgetButtonsTest.php
   @@ -100,19 +101,19 @@ class ParagraphsExperimentalWidgetButtonsTest extends BrowserTestBase {
    
        $this->getSession()->getPage()->findButton('field_paragraphs_1_edit')->press();
   -    $this->checkParagraphInMode('field_paragraphs_0', 'closed');
   +    $this->checkParagraphInMode('field_paragraphs_0', 'edit');
        $this->checkParagraphInMode('field_paragraphs_1', 'edit');
    
        // "Edit all" disables autocollapse.
   

   Ah, so we actually had explicit test coverage for the old behavior, interesting.

   The comment here needs an update I think, not correct anymore if autocollapse is not enabled in the first place in this context.

Fixing comments as suggested above. :)

Yes, now it looks nice, committed.