While working on #2766509: Gracefully handle a non-existent cache service like cache.backend.memcache I noticed several deprecated method calls. Attached patch replaces these calls with their new counterparts.

CommentFileSizeAuthor
#14 replace_deprecated_function_CKEditorLoadingTest-2908842-14.patch5.21 KBkunalgautam
#6 replace_deprecated_function_calls_CKEditorLoadingTest-2908842-5.patch5.15 KBkarthikkumarbodu
replace-deprecated-function-calls.patch5.19 KBlegolasbo

Comments

legolasbo created an issue. See original summary.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Issue tags: +Novice

Tagged this novice because it's a simple review.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Looks solid, but I don't think we usually do these kinds of patches as a one-off.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, replace-deprecated-function-calls.patch, failed testing. View results

karthikkumarbodu’s picture

karthikkumarbodu commented
Issue tags: +Needs re-roll
karthikkumarbodu’s picture

karthikkumarbodu commented
Status: Needs work » Needs review
Issue tags: -Needs re-roll
StatusFileSize
new replace_deprecated_function_calls_CKEditorLoadingTest-2908842-5.patch5.15 KB
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Patch still applies, and I rtbc'd it before. Still the same caveat that I don't think we do these oneoffs.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs work
Related issues: +#2735005: Convert all Simpletest web tests to BrowserTestBase (or UnitTestBase/KernelTestBase)

Thanks @karthikkumarbodu and @legolasbo!

We should replace deprecated functions by concept, rather than by file. Reference: https://www.drupal.org/core/scope#files

Marking NW to rescope for that, although I'd check to see whether issues to replace them across all of core already exist. In the case of assertNoRaw(), such a cleanup should probably be postponed until all simpletest web tests are converted to browser tests (which is being done in #2735005: Convert all Simpletest web tests to BrowserTestBase (or UnitTestBase/KernelTestBase)).

Thanks!

ivan berezhnov’s picture

ivan berezhnov commented
Issue tags: +CSKyiv18

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

kunalgautam’s picture

kunalgautam commented
Assigned: Unassigned » kunalgautam
kunalgautam’s picture

kunalgautam commented
StatusFileSize
new replace_deprecated_function_CKEditorLoadingTest-2908842-14.patch5.21 KB

Replaced deprecated function from the CKEditorLoadingTest file.

kunalgautam’s picture

kunalgautam commented
Assigned: kunalgautam » Unassigned
Status: Needs work » Needs review
ankitsingh0188’s picture

ankitsingh0188
he/him
Primary language English
Location Pune
commented

#14 Patch looks good to me. Good to move it to RTBC.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

quietone’s picture

quietone commented
Status: Needs review » Closed (duplicate)
Issue tags: -refactoring, -Unit tests, -code cleanup

@kkalashnikov and @ankitsingh0188 an issue set to needs work does not always need a patch. #8 stated this needed rescoping and a check for related issues.

This was fixed in #3198400: Convert assertions involving use of xpath on input tags to WebAssert and #2867959: Replace usages of deprecated AssertLegacyTrait::assertIdentical.

Closing as a duplicate.