@see http://cgit.drupalcode.org/webform/tree/ISSUE_TEMPLATE.html
Anonymous form submissions create a session cookie. As a result, any further navigation on the site by the user will not hit varnish cached versions of pages and resources. Since Varnish is very heavily relied on for caching anonymous web traffic, this may result in performance and scalability issues. Examining the code, it seems that session variables are only used for bridging anonymous user submission data to logged in users once those users log in or create an account (see setAnonymousSubmission).
Would it be possible to use a client side data management method which does not rely on session variables?
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | anonymous_form-2907459-9.patch | 11.99 KB | jrockowitz |
| #7 | anonymous_form-2907459-6.patch | 5.81 KB | jrockowitz |
| #4 | anonymous_form-2907459-4.patch | 766 bytes | jrockowitz |
Comments
Comment #2
jrockowitz commentedRight now, there is no way to use client-side storage to track and convert anonymous submissions.
Still, 'anonymous submissions' should only be tracked when a user can 'view own webform submissions'.
The most immediate solution is to check for 'view own submission' in WebformSubmissionStorage:: setAnonymousSubmission.
Comment #3
jrockowitz commentedThe Webform module for D7 checks if the current user can 'access own webform submissions'.
@see http://cgit.drupalcode.org/webform/tree/webform.module?h=7.x-4.x#n3411
Comment #4
jrockowitz commentedThe attached patch checks if the current user can 'access own webform submissions'.
I am willing to bet the attached untested patch breaks a test or two.
We probably need to add a warning to 'Convert anonymous user drafts and submissions to authenticated user.' that says anonymous users must be able to access their own webform submissions.
Comment #7
jrockowitz commentedComment #10
jrockowitz commentedComment #11
jrockowitz commentedComment #13
jrockowitz commentedI committed the patch. Please download the latest dev release to review.
Comment #14
jrockowitz commentedThis issue has caused this regression #2908808: Impossible to limit the number of submission by user. I am most likely going to revert the commit and approach the problem with a different solution.