Configuration import fails

Probably some module version mismatch (we're in Alpha, there are still a lot of incompatible changes), or you haven't created the "search_content" view on that site, or you need to clear the cache before doing the import.

One problem we definitely had was the missing dependency on the view. That should now be resolved, though.
If it's still not working, this could be a caching issue? Could you try disabling caching for type plugins with the attached patch and then trying the whole import again?
(Or, alternately, send me the files you're trying to import so I can reproduce this more easily.)

If it's the caching, we want to resolve this before a stable release.

This still happens if the view and the search are imported at the same time, I suspect stale plugin caches

The issue is the static cache on \Drupal\search_api_autocomplete\Plugin\search_api_autocomplete\search\ViewsDeriver isn't cleared by the code in search_api_autocomplete_view_insert()

Because \Drupal\Component\Plugin\Discovery\DerivativeDiscoveryDecorator::getDeriver has a static cache - which is #2880682: Derived discovery can result in rebuilding of out of date data (e.g. Block)

I confirm that I had to do a drush cr to be able to import the config.

In my case it was during a full site config import on a fresh database.

The issue still appears for me, even after a drush cr.

I'm under D8.6.2, with Search Autocomplete Version: 8.x-1.1

"Unknown search plugin with ID 'views:gref_articles_search_view'" at /var/www/html/modules/search_api_autocomplete/src/Utility/PluginHelper.php line 71,

This error also occurs for me with a fresh site installation pulling from my exported configurations. Only performing a drush cr and then reimporting clears the error.

This is running on the latest dev of Search API Autocomplete, the latest official release of Search API, and using Search API Pages for the autocomplete page.

We use drush site install with --existing-config and have 2 views with each an autocomplete. On config import we get an error for one of the autocomplete yaml's :

Unexpected error during import with operation create for search_api_autocomplete.search.sg_search: Unknown search plugin with ID 'views:sg_search'

The view is properly listed as a dependency for the autocomplete config.

After a manual install and a cim, with a drush cr the config can be imported but this wont work for us as we use drush si.

This has to be a cache issue.

Re-opening this issue as it definitely is a bug.

The search_api_autocomplete SearchPluginDeriverBase has a static cache $derivatives that breaks our config import:

 [notice] Synchronized configuration: create views.view.contacts.
 [notice] Synchronized configuration: create search_api_autocomplete.search.contacts.
 [notice] Synchronized configuration: create views.view.sg_search.
 [notice] Synchronized configuration: create search_api_autocomplete.search.sg_search.
 [notice] Finalizing configuration synchronization.
In ConfigImportCommands.php line 259:

Unexpected error during import with operation create for search_api_autocomplete.search.sg_search: Unknown search plugin with ID 'views:sg_search'

On the first run of ViewsDeriver::getDerivativeDefinitions the static cache is created (for search_api_autocomplete.search.contacts) but for the second one (search_api_autocomplete.search.sg_search) it uses the static cache that doesn't know about the second view (views.view.sg_search).
The static cache isn't updated when a another view is added (either by module installation or config sync).

Updated the issue summary.

Ah, thanks a lot for investigating and re-opening!
It indeed makes sense that the static cache would lead to errors in this case. Unfortunately, it’s not particularly easy clearing that – I think the attached patch provides the simplest and cleanest option. (But I’m open for suggestions.)

Please test/review!

Patch overall looks solid. I have one nitpick:

1. +++ b/src/Controller/AutocompleteController.php
   @@ -82,7 +82,7 @@ public function autocomplete(SearchInterface $search_api_autocomplete_search, Re
   -    if (!$search->status()|| !$search->hasValidIndex()) {
   +    if (!$search->status() || !$search->hasValidIndex()) {
   

   This is unrelated, but correct.

2. +++ b/tests/src/Kernel/ViewsTest.php
   @@ -155,7 +155,7 @@ protected function collectConditions(array $conditions) {
   -   * @see search_api_autocomplete_form_views_exposed_form_alter()
   +   * @see          search_api_autocomplete_form_views_exposed_form_alter()
   

   This seems unrelated (and wrong).

Oops, thanks! Seems I accidentally hit TAB there while thinking a different window was focused (or something like that).

(Waiting for someone confirming that this indeed resolves the problem for them.)

Sorry for the late reply, looks good!

Alright, great to hear, thanks for testing and reporting back!
Committed.
Thanks again, everyone!