We will need all commerce customers to have a phone number field, since we use that for lookup in addition to email. I think this is just a field added to the user, but we may want to check how addresses are done.

CommentFileSizeAuthor
#8 2901399-8.patch1.59 KBrakesh.gectcr
#6 customer_phone-2901399-6.patch1.47 KBTylerMarshall
#4 customer_phone-2901399-4.patch1.43 KBTylerMarshall
#4 interdiff.txt970 bytesTylerMarshall
#2 customer_phone-2901399-2.patch1.41 KBTylerMarshall

Comments

smccabe created an issue. See original summary.

TylerMarshall’s picture

TylerMarshall commented
Status: Active » Needs work
StatusFileSize
new customer_phone-2901399-2.patch1.41 KB

This patch adds a phone number field to the user via the configuration in commerce_pos. Still needs to be exposed to user and probably some sort of schema file?

subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented 
+++ b/config/install/field.field.user.user.commerce_pos_phone_number.yml
@@ -0,0 +1,21 @@
+uuid: 25905bbe-b4fd-4493-97c0-804769288c42

UUIDs are instance specific, and they should not get into yml files inside config/install

+++ b/config/install/field.field.user.user.commerce_pos_phone_number.yml
@@ -0,0 +1,21 @@
+field_type: telephone

Since this field type is already provided by the core, you don't need to provide a schema for this. Still, if you want to make sure that everything is okay, you can use https://www.drupal.org/project/config_inspector

Drupal Commerce Payment also creates user fields, you can refer the code

TylerMarshall’s picture

TylerMarshall commented
StatusFileSize
new interdiff.txt970 bytes
new customer_phone-2901399-4.patch1.43 KB

Adds telephone field in backend.

TylerMarshall’s picture

TylerMarshall commented
Status: Needs work » Needs review
TylerMarshall’s picture

TylerMarshall commented
StatusFileSize
new customer_phone-2901399-6.patch1.47 KB

Adds dependencies on commerce_pos module.

subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented
Status: Needs review » Needs work

nitpicks

  1. +++ b/config/install/field.field.user.user.commerce_pos_phone_number.yml
@@ -0,0 +1,23 @@
+_core:
+  default_config_hash: XFwyb8J8K4f6pLeDbXxUaXk92FM3dO_C2-kbxJuyNhM

    hash codes are instance specific, and shouldn't be there when you are installing a config 

  2. +++ b/config/install/field.field.user.user.commerce_pos_phone_number.yml
@@ -0,0 +1,23 @@
\ No newline at end of file

    Please add a new line

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Status: Needs work » Needs review
StatusFileSize
new 2901399-8.patch1.59 KB

Looks like straight forward one. Please review it.

subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented
Status: Needs review » Reviewed & tested by the community

Looks ok.

smccabe’s picture

smccabe commented
Status: Reviewed & tested by the community » Fixed

Thanks guys, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.