Closed (fixed)
Project:
Commerce Point of Sale (POS)
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 Aug 2017 at 23:11 UTC
Updated:
20 Sep 2017 at 16:35 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
TylerMarshall commentedThis patch adds a phone number field to the user via the configuration in commerce_pos. Still needs to be exposed to user and probably some sort of schema file?
Comment #3
subhojit777UUIDs are instance specific, and they should not get into yml files inside
config/installSince this field type is already provided by the core, you don't need to provide a schema for this. Still, if you want to make sure that everything is okay, you can use https://www.drupal.org/project/config_inspector
Drupal Commerce Payment also creates user fields, you can refer the code
Comment #4
TylerMarshall commentedAdds telephone field in backend.
Comment #5
TylerMarshall commentedComment #6
TylerMarshall commentedAdds dependencies on commerce_pos module.
Comment #7
subhojit777nitpicks
hash codes are instance specific, and shouldn't be there when you are installing a config
Please add a new line
Comment #8
rakesh.gectcrLooks like straight forward one. Please review it.
Comment #9
subhojit777Looks ok.
Comment #11
smccabe commentedThanks guys, committed.