Hello
I was faced with the unavailability of the rabbit hole functionality for the commerce products.

CommentFileSizeAuthor
#14 2900548-commerce-support-13.patch2.23 KBleendertdb
#12 interdiff-2900548-11-12-do-not-test.diff508 bytesleendertdb
#12 2900548-commerce-support-12.patch1.9 KBleendertdb
#11 interdiff-2900548-3-11-do-not-test.diff1.69 KBdaniel korte
#11 2900548-commerce-support-11.patch1.74 KBdaniel korte
#3 commerce_support-2900548-3.patch1.77 KBimyaro
#2 commerce_support-2900548-2.patch1.77 KBimyaro

Comments

zvse created an issue. See original summary.

imyaro’s picture

imyaro commented
Status: Active » Needs review
StatusFileSize
new commerce_support-2900548-2.patch1.77 KB

Please review my patch - I think that it might be helpful for many rabbit hole and commerce module users.

I don't know if we should add Commerce Orders support, because usually it not needed for orders.
Other commerce entities does not have it own page and don't think that we will need to add it.

Thanks

imyaro’s picture

imyaro commented
StatusFileSize
new commerce_support-2900548-3.patch1.77 KB

Updated patch.
Changed plugin name from hr_commerce_product to rh_commerce product.

0sarah0al’s picture

0sarah0al commented

The patch works..
Awesome..

Thanks alot

kala4ek’s picture

kala4ek
Primary language Russian
Location 🇷🇺 Novosibirsk
commented
Status: Needs review » Reviewed & tested by the community

Works like a charm in production.

steveoriol’s picture

steveoriol
Location Grenoble 🇫🇷
commented

+1, the patch works on 1.x-dev, permissions OK...

abramm’s picture

abramm
Primary language Ukrainian
Location Lutsk
commented

RTBC.
I'm using this patch on production for almost a year.

hitchshock’s picture

hitchshock
Location Ukraine
commented

RTBC.
Patch works good.

rollins’s picture

rollins commented

Great work zvse!
Thank you.

markdc’s picture

markdc
Location Selters
commented
Status: Reviewed & tested by the community » Needs work

The option to override Rabbit Hole settings per product entity does not work. I see the Rabbit Hole Settings form on the commerce product form. But choosing another option has no effect on the form, nor does saving a different value.

Steps to reproduce:

  1. Enabled the option to override Rabbit Hole settings for a product type
  2. Edit a product
  3. Open the Rabbit Hole Settings pane in the sidebar
  4. Change Rabbit Hole Settings to "Page not found" or something other than "Global product behavior"
  5. Save
  6. Edit product again and no change to form was made
daniel korte’s picture

daniel korte
he/him/his
Primary language English
Location Brooklyn, NY
commented
Title: Support for the commerce entities. » Support for commerce products
StatusFileSize
new 2900548-commerce-support-11.patch1.74 KB
new interdiff-2900548-3-11-do-not-test.diff1.69 KB

I cleaned up the patch in #3 so this new module matches the other sub modules in RH more closely.

Also, I can confirm the issue in #10 exists, but not sure why.

leendertdb’s picture

leendertdb commented
StatusFileSize
new 2900548-commerce-support-12.patch1.9 KB
new interdiff-2900548-11-12-do-not-test.diff508 bytes

I tested the patch in #11 and it works perfectly for the commerce_product entity. I also took the time to debug the issue noticed in #10. I found out that one of the commerce_product form parent elements has a form API parameter '#tree' => TRUE. This causes all child fieldsets (of which the rabbit_hole form is one) to be posted in a hierarchical format as well.

However the rabbit_hole module itself expects all properties to be available in the top level $form_state values array, here an example:

    if ($form_state->getValue('rh_is_bundle')) {

I added a new patch based on #11 which adds a '#tree' => FALSE property to the main rabbit_hole form element in src/FormManglerService.php. With this extra line the override per commerce_product works as expected.

Updated patch and interdiff attached.

leendertdb’s picture

leendertdb commented
Status: Needs work » Needs review
leendertdb’s picture

leendertdb commented
StatusFileSize
new 2900548-commerce-support-13.patch2.23 KB

Rerolling patch of #12 (made a mistake while generating the diff, it did not apply). Changes are exactly the same.

daniel korte’s picture

daniel korte
he/him/his
Primary language English
Location Brooklyn, NY
commented
Status: Needs review » Reviewed & tested by the community

Nice work @leendertdb! I am surprised this wasn’t caught until now. That fix does the trick. Patch looks good to me.

loze’s picture

loze commented

Patch works as advertised. Thanks!
+1

stefdewa’s picture

stefdewa commented

+1 for RTBC!

k.skarlatos’s picture

k.skarlatos commented

This breaks multilingual sites. When i enable rabbit hole for a product type with a Page not found behavior, i get page not found for every language.

  • Matroskeen committed 5ba262c on 8.x-1.x authored by leendertdb 
    Issue #2900548 by leendertdb, zvse, Daniel Korte, markdc: Support for...
matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
Status: Reviewed & tested by the community » Fixed

I'm happy to announce that the latest patch was committed to 8.x-1.x branch and will be available in the next release.
It was proved by many people and our test coverage (#3177826: Add behavior invocation test coverage for rh_commerce module, #3177818: Add form additions test coverage for rh_commerce module).

@ k.skarlatos, if there are any issues with the multilingual setup, feel free to create a new issue (I believe it's not commerce-specific).

Thank you all for your contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.