Attempt to create a base field bundle override of field Metatags without an entity_type in Drupal\Core\Field\Entity\BaseFieldOverride

Someone contacted me about what might be the same problem. Would you mind testing to see if this fixes the problem? Thanks.

Sorry, try this one (I forgot that $entity_type was an object, not a string).

I have got the same error message without patch applied.
When patch #3 is applied I have got a different error message:

( ! ) Fatal error: Call to a member function getFieldStorageDefinition() on null in /www/core/lib/Drupal/Core/Field/Entity/BaseFieldOverride.php on line 114
Call Stack
# Time Memory Function Location
1 0.0000 571568 {main}( ) ../index.php:0
2 0.0057 932720 Drupal\Core\DrupalKernel->handle( ) ../index.php:19
3 0.0180 2161368 Stack\StackedHttpKernel->handle( ) ../DrupalKernel.php:656
4 0.0180 2161480 Drupal\Core\StackMiddleware\NegotiationMiddleware->handle( ) ../StackedHttpKernel.php:23
5 0.0180 2161872 Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle( ) ../NegotiationMiddleware.php:50
6 0.0180 2162304 Drupal\page_cache\StackMiddleware\PageCache->handle( ) ../ReverseProxyMiddleware.php:47
7 0.0181 2162824 Drupal\page_cache\StackMiddleware\PageCache->pass( ) ../PageCache.php:78
8 0.0181 2162904 Drupal\Core\StackMiddleware\KernelPreHandle->handle( ) ../PageCache.php:99
9 0.0243 2618168 Drupal\Core\StackMiddleware\Session->handle( ) ../KernelPreHandle.php:47
10 0.0294 2792072 Symfony\Component\HttpKernel\HttpKernel->handle( ) ../Session.php:57
11 0.0295 2792928 Symfony\Component\HttpKernel\HttpKernel->handleRaw( ) ../HttpKernel.php:64
12 0.1011 5244512 call_user_func_array:{/www/vendor/symfony/http-kernel/HttpKernel.php:144} ( ) ../HttpKernel.php:144
13 0.1011 5244712 Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}( ) ../HttpKernel.php:144
14 0.1011 5244960 Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext( ) ../EarlyRenderingControllerWrapperSubscriber.php:97
15 0.1013 5256984 Drupal\Core\Render\Renderer->executeInRenderContext( ) ../EarlyRenderingControllerWrapperSubscriber.php:124
16 0.1013 5257432 Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}( ) ../Renderer.php:574
17 0.1013 5257480 call_user_func_array:{/www/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php:123} ( ) ../EarlyRenderingControllerWrapperSubscriber.php:123
18 0.1013 5258176 Drupal\Core\Controller\FormController->getContentResult( ) ../EarlyRenderingControllerWrapperSubscriber.php:123
19 0.1044 5680840 Drupal\Core\Form\FormBuilder->buildForm( ) ../FormController.php:74
20 0.4237 25273920 Drupal\Core\Form\FormBuilder->processForm( ) ../FormBuilder.php:314
21 0.7694 32494200 Drupal\Core\Form\FormSubmitter->doSubmitForm( ) ../FormBuilder.php:585
22 0.7694 32494312 Drupal\Core\Form\FormSubmitter->executeSubmitHandlers( ) ../FormSubmitter.php:51
23 3.0694 41421640 call_user_func_array:{/www/core/lib/Drupal/Core/Form/FormSubmitter.php:111} ( ) ../FormSubmitter.php:111
24 3.0694 41425328 content_translation_form_language_content_settings_submit( ) ../FormSubmitter.php:111
25 8.8734 51175872 Drupal\Core\Field\FieldConfigBase->isTranslatable( ) ../content_translation.admin.inc:341
26 8.8734 51175872 Drupal\Core\Field\Entity\BaseFieldOverride->getFieldStorageDefinition( ) ../FieldConfigBase.php:329

Same configuration with metatag module disabled shows no errors.

FYI the patch was from giangi.vigazzola.

@wanjee: What happens if you add this to the top of the function?

  \Drupal::logger('metatag')->notice($entity_type->id());

.. so that it looks like this:

function metatag_entity_base_field_info_alter(&$fields, EntityTypeInterface $entity_type) {
  \Drupal::logger('metatag')->notice($entity_type->id());
  $fields['metatag'] = BaseFieldDefinition::create('map')

I'm interested to know what the last entity type recorded is.

It loops over types like:

node
user
menu_link_content
file
taxonomy_term
paragraph
crop
search_api_task

With patch applied: it fails after a lot of iterations
Without patch applied: it fails after first iteration of search_api_task

Ah. So maybe the code needs to exclude certain entity types, or maybe work out some entity properties that would be required in order for the Metatag functionality to be included?

Yes indeed, paragraphs, crop, search_api_task should probably not have any metatags

Does this help in any way?

Rerolled the patch.

Applied patch #15.

Submission of "Content language and translation" form does not fail anymore.
I however only have a "Metatags" checkbox for taxonomy terms anymore. Is this the expected behavior ?

Thanks !

@wanjee: Where are you seeing that checkbox?

In admin/config/regional/content-language form.

I see that a checkbox appears for content types only if I add the "metatag" field to my entity so it's ok, sorry :)
Checkboxes appear however for all vocabularies even with no "metatag" field attached.

@DamienMcKenna I'm uploading this patch to try to fix tests - I changed the logic that checks for a URI callback (which is rarely used) to check for a canonical route, which I think is what you wanted to check for. If I'm wrong let me know and I'll jump back in.

@samuel.mortenson: yeah, that's what I was looking for! Thanks!

@wanjee: Please test out the patch above and let me know if it fixes the problem for you.

Patch #20 is working.

@Ruedische: Thanks.

@jagundez / @wanjee: Could you please let me know if the patch in #20 solves the problem for you? Thanks.

Hello guys,

Thank you for the patch, I've got the error since few days...

Applied the patch #15 2 days ago, and it works (need to test the #20 yet).

Unfortunately, now, in page edition, I've an extra HTML in the title (see file attached).

Am I the only one?

Thank you

After apply the #20 patch I had the same error than #5 and reloading the page, all the translatable fields but metatags where selected properly and the following error appeared at the top of the page:

Notice: Undefined index: Metatags in Drupal\Core\Field\Entity\BaseFieldOverride->getBaseFieldDefinition() (line 153 of core/lib/Drupal/Core/Field/Entity/BaseFieldOverride.php).

Drupal\Core\Field\Entity\BaseFieldOverride->getBaseFieldDefinition() (Line: 114)
Drupal\Core\Field\Entity\BaseFieldOverride->getFieldStorageDefinition() (Line: 329)
Drupal\Core\Field\FieldConfigBase->isTranslatable() (Line: 341)
content_translation_form_language_content_settings_submit(Array, Object)
call_user_func_array('content_translation_form_language_content_settings_submit', Array) (Line: 111)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object) (Line: 51)
Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object) (Line: 585)
Drupal\Core\Form\FormBuilder->processForm('language_content_settings_form', Array, Object) (Line: 314)
Drupal\Core\Form\FormBuilder->buildForm('language_content_settings_form', Object) (Line: 74)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 574)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
call_user_func_array(Object, Array) (Line: 144)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 64)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 50)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 656)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

That means that the test coverage needs to be expanded.

Anyone have any thoughts on how to make the JSON output still work if metatag_entity_base_field_info_alter() is removed?

Hi guys, having the same problem. But none of the patches didn't work for me.

On submit I've got:

The website encountered an unexpected error. Please try again later.
Error: Call to a member function getFieldStorageDefinition() on null in Drupal\Core\Field\Entity\BaseFieldOverride->getFieldStorageDefinition() (line 114 of core/lib/Drupal/Core/Field/Entity/BaseFieldOverride.php).
Drupal\Core\Field\Entity\BaseFieldOverride->getFieldStorageDefinition() (Line: 329)
Drupal\Core\Field\FieldConfigBase->isTranslatable() (Line: 341)
content_translation_form_language_content_settings_submit(Array, Object)
call_user_func_array('content_translation_form_language_content_settings_submit', Array) (Line: 111)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object) (Line: 51)
Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object) (Line: 585)
Drupal\Core\Form\FormBuilder->processForm('language_content_settings_form', Array, Object) (Line: 314)
Drupal\Core\Form\FormBuilder->buildForm('language_content_settings_form', Object) (Line: 74)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 574)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
call_user_func_array(Object, Array) (Line: 144)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 64)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 50)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 656)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

After page reload:

Notice: Undefined index: Metatags in Drupal\Core\Field\Entity\BaseFieldOverride->getBaseFieldDefinition() (line 153 of core/lib/Drupal/Core/Field/Entity/BaseFieldOverride.php).
Drupal\Core\Field\Entity\BaseFieldOverride->getBaseFieldDefinition() (Line: 114)
Drupal\Core\Field\Entity\BaseFieldOverride->getFieldStorageDefinition() (Line: 329)
Drupal\Core\Field\FieldConfigBase->isTranslatable() (Line: 341)
content_translation_form_language_content_settings_submit(Array, Object)
call_user_func_array('content_translation_form_language_content_settings_submit', Array) (Line: 111)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object) (Line: 51)
Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object) (Line: 585)
Drupal\Core\Form\FormBuilder->processForm('language_content_settings_form', Array, Object) (Line: 314)
Drupal\Core\Form\FormBuilder->buildForm('language_content_settings_form', Object) (Line: 74)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 574)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
call_user_func_array(Object, Array) (Line: 144)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 64)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 50)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 656)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

I tried to apply patches #3 #15 and #20 separately.

@DamienMcKenna Applied patch #20. It seems getFieldStorageDefinition error is back there

Adding related issues:

• https://www.drupal.org/node/2636852 (Issue which introduced the problematic base field info alter hook: Make Metatag fields available as JSON)
• https://www.drupal.org/node/2899365 (I'd say that the cause of the problem is the same here as well)

My opinion:

Using an alter hook to introduce a new (base) field is a really-really bad idea. It's for alter existing base fields. For first, let's change the alter hook to a normal base field info.

http://cgit.drupalcode.org/drupal/tree/core/lib/Drupal/Core/Entity/Entit...

@huzooka: Thanks for taking the time to dig into this. Lets see what the testbot says.

@DamienMcKenna existing tests are fine.

Could you please help us and describe what kind of test do we need here?

I'd say that a functional test would be enough to cover the scope of this bug (test that the content translation form is usable). What else should be covered (and how)?

The #33 patch fixes everything. Thank you!

I think with the functional test that you describe would be enough for this issue, more tests could be in a follow-up.

For the tests, all I'd really like is a scenario that shows the problem in the current codebase as I still haven't been able to replicate the bug locally.

Just another confirm that #33 fixed this issue. Thanks.

Test doesn't passes CS.

The test-only patch is *supposed* to fail, that's the point :-)

A slight cleanup of #41.

A test-only version of #46; this should fail.

As expected the test fails on this:

    $this->drupalPostForm(NULL, [], 'Save configuration');
    $this->assertResponse(200);

That means it hits an error saving the configuration, which is expected.

I had the same issue, I am using Ligthning distribution, with translations and metatag. Tested #46 and works fine.

Thanks
The patch #46 works in d8.3.7.

Patch could not be applied in Drupal 8.3.7, Meta tag - version: '8.x-1.2'

Updated hook comment.

Updating patch file path.

#58 works for me, thanks
metatag 1.2

Following the standards for the Tests, the name of the class should end with the word 'test' I think, so should be 'EnsureContentTranslationWorksTest' other than that, everything works fine and looks good, so this could be a RTBC.

#58 works for me too on 8.x-1.2.

Rolled the #58 patch against a production site on the dev-1.x c923b26 version and that works as well.

Setting status to RTBC.

#58 work like a charm for me ! Push it ;)

Dear Edurenye,

All the other test files were having the same naming patterns. Could you please confirm that all class names for test need to be renamed in Metatag module? If so, that needs to be handled separately.

Thanks,
Deepak R

You are right, all the Functional Tests from Metatag do not have the 'Test' suffix, but in the kernel tests (MetatagManagerTest) have it, and in general in core and other modules is that way. Anyway as you say that would be another issue to rename all the Functional tests and discuss about it or why was done that way, maybe there is another reason I don't know.

So, RTBC+1

Just stumbled across the error with a setup of paragraphs module and metatag (8.x-dev) while enabling translation for several paragraphs fields.

Patch #58 fixed the issue.

Dear Mario Steinitz,

Paragraph fields are not translatable. You may have to translate the entity which you use a paragraph. Seems paragraph module will consider the translation as another entry in the paragraph entity.

"Out of context"

Thanks,
Deepak R

Lets try the tests on their own again.

Ok, that is as expected.

Committed. Thanks everyone for your help fixing this!

@deepak_zyxware: The paragraph reference field isn't, but the fields within the paragraphs are. Hence, I was talking about enabling translation for the paragraph entities and their fields, which wasn't possible without above fix.

@DamienMcKenna: Thanks for commiting.

I think there was a misunderstanding about the Paragraph fields. Anyway, thanks for everyone's help getting this fixed.

Yes, the fix is very much appreciated. Committed the new metatag version to the current development site, I've been talking about before. Works like a charm.

Thanks for the patch. works like a charm too. :)