Problem/Motivation

Currently RedACTO has composer dependency on BS Base commit http://cgit.drupalcode.org/bs_base/commit/?id=d8bc7fd as after #2890739: Bootstrap assets should go to libraries themes were broken.

We should have dependency on latest alpha version. We should have dependency on BS Lib latest alpha version too.

Remaining tasks

  • Remove dependency on BS Base commit in composer.json.
  • Update composer, reinstall distribution and fix possible errors.
  • Recompile SASS and fix any compilation error in both themes.
  • Check visual look and fix possible problems.
CommentFileSizeAuthor
#4 remove_composer-2899651-4.patch415.25 KBnjagojevic
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

njagojevic created an issue. See original summary.

njagojevic’s picture

njagojevic CreditAttribution: njagojevic commented
Issue summary: View changes
njagojevic’s picture

njagojevic CreditAttribution: njagojevic commented
Assigned: Unassigned » njagojevic
njagojevic’s picture

njagojevic CreditAttribution: njagojevic commented
FileSize
remove_composer-2899651-4.patch415.25 KB

First patch. Updated BS Base dependency. Fixed compilation errors.

njagojevic’s picture

njagojevic CreditAttribution: njagojevic commented
Status: Active » Needs review
devlada’s picture

devlada CreditAttribution: devlada commented
Status: Needs review » Fixed

Tested. As far as I can see it works well.

  • devlada committed 9e7c1a3 on 8.x-1.x authored by njagojevic 
    Issue #2899651 by njagojevic, devlada: Remove composer dependency on BS...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.