Sometimes we design a teaser view mode to wrap the entire content in an anchor element. For example:

<a href="/node/1">
  <h2>Title</h2>
  <div>Short description</div>
  <img src="thumbnail.jpg" />
</a>

Contextual links inserts additional links inside this anchor. It is not valid HTML to have anchors inside anchors, and the contextual links do not work. For example:

<a href="/node/1">
  <h2>Title</h2>
  <div>Short description</div>
  <img src="thumbnail.jpg" />
  <button>Open  configuration options</button>
  <ul class="contextual-links">
    <li><a href="#">Quick edit</a></li>
    <li><a href="#">Edit</a></li>
    <li><a href="#">Delete</a></li>
  </ul>
</a>

I think the expected behaviour is that the contextual trigger and contextual links are not injected into the DOM if the contextual region is a descendent of an anchor.

CommentFileSizeAuthor
#18 Screenshot from 2021-07-15 15-41-45.png218.86 KBdhirendra.mishra
#18 2898875-18.patch1.37 KBdhirendra.mishra
#16 contextual_links_should-2898875-16.patch1.37 KBseanr
#15 contextual_links_should-2898875-15.patch1.21 KBgro
#6 contextual_links_should-2898875-6.patch1.58 KBgargsuchi
#3 contextual_links_should-2898875-3.patch1.6 KBkeeganstreet
#2 contextual_links_should-2898875-2.patch641 byteskeeganstreet

Comments

keeganstreet created an issue. See original summary.

keeganstreet’s picture

keeganstreet commented
StatusFileSize
new contextual_links_should-2898875-2.patch641 bytes
keeganstreet’s picture

keeganstreet commented
StatusFileSize
new contextual_links_should-2898875-3.patch1.6 KB

Added patch for 8.4.x which includes es6.js file.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

gargsuchi’s picture

gargsuchi commented
StatusFileSize
new contextual_links_should-2898875-6.patch1.58 KB

Reroll attached against 8.5.x.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

chop’s picture

chop commented
Version: 8.6.x-dev » 8.7.x-dev
Status: Active » Needs review

Time to test against latest dev branch.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

gge’s picture

gge commented

With this patch blocks added using layout builder can't be edited anymore...

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

nwom’s picture

nwom commented
Status: Needs review » Needs work

Setting to NW due to the comment in #12.

gro’s picture

gro commented
StatusFileSize
new contextual_links_should-2898875-15.patch1.21 KB

Re-rolled patch for Core 8.9

seanr’s picture

seanr
he/him
commented
StatusFileSize
new contextual_links_should-2898875-16.patch1.37 KB

Added a patch against 9.2.x.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

dhirendra.mishra’s picture

dhirendra.mishra commented
StatusFileSize
new 2898875-18.patch1.37 KB
new Screenshot from 2021-07-15 15-41-45.png218.86 KB

Re-rolled it against 9.3.x and fixed on white-space issue which you can see in attached screenshot.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Closed (won't fix)
Issue tags: +Bug Smash Initiative

Contextual links are controlled from your template.

If your template is outputting a wrapping link, you can simply choose not to output the title_suffix variable which renders the contextual link.