Contextual links should not be added inside another link [#2898875]

Sometimes we design a teaser view mode to wrap the entire content in an anchor element. For example:

<a href="/node/1">
  <h2>Title</h2>
  <div>Short description</div>
  <img src="thumbnail.jpg" />
</a>

Contextual links inserts additional links inside this anchor. It is not valid HTML to have anchors inside anchors, and the contextual links do not work. For example:

<a href="/node/1">
  <h2>Title</h2>
  <div>Short description</div>
  <img src="thumbnail.jpg" />
  <button>Open  configuration options</button>
  <ul class="contextual-links">
    <li><a href="#">Quick edit</a></li>
    <li><a href="#">Edit</a></li>
    <li><a href="#">Delete</a></li>
  </ul>
</a>

I think the expected behaviour is that the contextual trigger and contextual links are not injected into the DOM if the contextual region is a descendent of an anchor.

Comment	File	Size	Author
#18	Screenshot from 2021-07-15 15-41-45.png	218.86 KB	dhirendra.mishra
#18	2898875-18.patch	1.37 KB	dhirendra.mishra
#18
#16	contextual_links_should-2898875-16.patch	1.37 KB	seanr
#16	9.2.x: PHP 7.3 & MySQL 5.7 Custom Commands Failed
#15	contextual_links_should-2898875-15.patch	1.21 KB	GRO
#15
#6	contextual_links_should-2898875-6.patch	1.58 KB	gargsuchi
#6	8.5.x: PHP 5.5 & MySQL 5.5 23,391 pass 8.7.x: PHP 7.2 & MySQL 5.5 Patch Failed to Apply
#3	contextual_links_should-2898875-3.patch	1.6 KB	keeganstreet
#3	8.5.x: PHP 7 & MySQL 5.5 Patch Failed to Apply
#2	contextual_links_should-2898875-2.patch	641 bytes	keeganstreet
#2	8.5.x: PHP 7 & MySQL 5.5 Patch Failed to Apply

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

1 August 2017 at 00:13

keeganstreet created an issue. See original summary.

Comment #2

keeganstreet CreditAttribution: keeganstreet at Deloitte Digital commented 1 August 2017 at 00:18

File	Size
contextual_links_should-2898875-2.patch	641 bytes
8.5.x: PHP 7 & MySQL 5.5 Patch Failed to Apply

Comment #3

keeganstreet CreditAttribution: keeganstreet at Deloitte Digital commented 1 August 2017 at 00:25

File	Size
contextual_links_should-2898875-3.patch	1.6 KB
8.5.x: PHP 7 & MySQL 5.5 Patch Failed to Apply

Added patch for 8.4.x which includes es6.js file.

Comment #4

1 August 2017 at 00:25

Version:

8.3.x-dev

» 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #5

1 August 2017 at 00:25

Version:

8.4.x-dev

» 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #6

gargsuchi CreditAttribution: gargsuchi at Salsa Digital for Department of Premier and Cabinet - Victoria, Australia commented 16 March 2018 at 06:57

File	Size
contextual_links_should-2898875-6.patch	1.58 KB
8.5.x: PHP 5.5 & MySQL 5.5 23,391 pass 8.7.x: PHP 7.2 & MySQL 5.5 Patch Failed to Apply

File

Size

contextual_links_should-2898875-6.patch

1.58 KB

8.5.x:
PHP 5.5 & MySQL 5.5 23,391 pass

8.7.x:
PHP 7.2 & MySQL 5.5 Patch Failed to Apply

Reroll attached against 8.5.x.

Comment #7

16 March 2018 at 06:57

Version:

8.5.x-dev

» 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #8

chOP CreditAttribution: chOP at Deloitte Digital commented 5 March 2019 at 06:43

Version:	8.6.x-dev	» 8.7.x-dev
Status:	Active	» Needs review

Time to test against latest dev branch.

Comment #9

5 March 2019 at 06:43

Version:

8.7.x-dev

» 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #10

5 March 2019 at 06:43

Version:

8.8.x-dev

» 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #11

5 March 2019 at 06:43

Version:

8.9.x-dev

» 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #12

gge CreditAttribution: gge commented 30 June 2020 at 11:42

With this patch blocks added using layout builder can't be edited anymore...

Comment #13

30 June 2020 at 11:42

Version:

9.1.x-dev

» 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Comment #14

NWOM CreditAttribution: NWOM commented 10 December 2020 at 14:10

Status:

Needs review

» Needs work

Setting to NW due to the comment in #12.

Comment #15

GRO CreditAttribution: GRO commented 23 February 2021 at 05:50

File	Size
contextual_links_should-2898875-15.patch	1.21 KB

Re-rolled patch for Core 8.9

Comment #16

seanr

he/him

CreditAttribution: seanr as a volunteer and commented 3 March 2021 at 23:58

File	Size
contextual_links_should-2898875-16.patch	1.37 KB
9.2.x: PHP 7.3 & MySQL 5.7 Custom Commands Failed

Added a patch against 9.2.x.

Comment #17

3 March 2021 at 23:58

Version:

9.2.x-dev

» 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #18

dhirendra.mishra CreditAttribution: dhirendra.mishra at Valuebound for Valuebound commented 15 July 2021 at 10:11

File	Size
2898875-18.patch	1.37 KB

Screenshot from 2021-07-15 15-41-45.png	218.86 KB

Re-rolled it against 9.3.x and fixed on white-space issue which you can see in attached screenshot.

Comment #19

15 July 2021 at 10:11

Version:

9.3.x-dev

» 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.