Steps to reproduce the bug:

  1. Create a custom ajax controller and ajax response
  2. Deliver views results in ajax
  3. Enable caching
  4. See that the currently active request object is not available if the views ajax response is cached.
CommentFileSizeAuthor
#21 2895584-21.patch711 bytesadinancenci
#8 drupal_views-2895584-empty_request-8.patch738 bytesweseze
#3 drupal_views-2895584-empty_request-3.patch849 bytesa.milkovsky

Comments

a.milkovsky created an issue. See original summary.

a.milkovsky’s picture

a.milkovsky
he/him
Location UTC +2
commented

FYI I have tried the patches in https://www.drupal.org/node/2849674, but it did not help.

a.milkovsky’s picture

a.milkovsky
he/him
Location UTC +2
commented
Assigned: a.milkovsky » Unassigned
Status: Active » Needs review
StatusFileSize
new drupal_views-2895584-empty_request-3.patch849 bytes

This is what I have came up with.

P.S. To reproduce the bug: I know that it is not easy to create a cacheable ajax responce in Drupal, as they are all POST requests in the core. But there will be a new initiative soon at https://www.drupal.org/project/ajax_assets_plus.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

andreymaximov’s picture

andreymaximov commented

Thanks, Alex.

The patch works really well for us.

a.milkovsky’s picture

a.milkovsky
he/him
Location UTC +2
commented

Thanks for the feedback, @AndreyMaximov. Do you think we can make it RSVP? We are using this patch already in production.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work
Issue tags: +Needs tests

I'm wondering whether we could add a test for this case ... It seems to be that you've been able to provide some good reproducable steps, so we could leverage that to write a test. Thank you for the existing fix already.

weseze’s picture

weseze commented
StatusFileSize
new drupal_views-2895584-empty_request-8.patch738 bytes

I'm experiencing the exact same issue, but without the ajax...

I basically have a view rendering teasers of a node type "download".
Those download nodes have a custom field (ds field) that generates a form.

First request that shows my page works fine, second request (from cache) gives a fatal error all because the request is empty.

The above patch fixed it for me. I had to manually apply it because it doesn't work against 8.4.3. Attached is a patch that does work against 8.4.3.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

a.milkovsky’s picture

a.milkovsky
he/him
Location UTC +2
commented

Thanks @weseze, the patch #8 works for me against Drupal 8.4.7.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

alexj12’s picture

alexj12 commented

While I won't have a chance to create a test at this time, I would like to confirm this is still an issue in 9.3 and the patch resolves the issue.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

adinancenci’s picture

adinancenci commented
Issue tags: -
StatusFileSize
new 2895584-21.patch711 bytes

Re-roll for 10.6.13