Problem/Motivation

Don't use custom string for method name. Also for the secret key.

Proposed resolution

Change the encrypt decrypt service method name.

CommentFileSizeAuthor
#3 change_service_callback-2890238-2.patch1.47 KBdishabhadra

Comments

manojapare created an issue. See original summary.

dishabhadra’s picture

dishabhadra commented
dishabhadra’s picture

dishabhadra commented
Assigned: dishabhadra » Unassigned
Status: Active » Needs review
StatusFileSize
new change_service_callback-2890238-2.patch1.47 KB

Kindly review my patch.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Assigned: Unassigned » rakesh.gectcr
rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Status: Needs review » Fixed

Thanks for your contribution.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Issue tags: +DIACWMay2020
kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Fixed » Reviewed & tested by the community
Issue tags: +Drupal 9 compatibility, +Drupal 9 porting weekend

This is marked fixed but no code was committed. Moving back to RTBC. Also adding relevant tags.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Reviewed & tested by the community » Fixed

Hmm... maybe this was fixed? I see a commit in the commit log. Normally a commit comment would show up in this issue like this:

https://www.drupal.org/project/galleryslider/issues/3139135#comment-1363...

How are you committing these patches?

(p.s. sorry for the noise... it took me 3 issues before I realized that there was something else going on.)

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Fyi, after discussing this with others, it appears that because this issue is for a different version (branch) than what the code was committed to, the commit comment won't show up here. You could probably get the commit to show up by 1) moving this back to RTBC, 2) switching the version to 2.0.0 (now that it exists), and 3) marking Fixed again. Never mind, I forgot this the commit comment happens during the commit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.