Allow Multiple Values Not Working in contextual filter in views for Views Taxonomy Term Name Depth

Hello Anishnirmal,

Use this patch to solve it.

Hi

Patch fails when no arguments are provided:

Drupal\Core\Database\InvalidQueryException: Query condition 'tn.tid IN ()' cannot be empty.

With this piece of code ('if' condition) you fix the problem:

    if (empty($tids)) {
      return FALSE;
    }
  
  // Rest of code.
  $subquery = db_select('taxonomy_index', 'tn');
  $subquery->addField('tn', 'nid');
  $where = db_or()->condition('tn.tid', $tids, $operator);
  $last = "tn";
  ..................

#4 I think fixes the problem .

Hi,
I have updated the patch. Please review.

#6 failed to apply. i manually applied and rerolled the patch.

Cane we get the interdiff for this ?

@here Kindly please add the interdiff file also with patch so that reviewer can review easily

Please see https://www.drupal.org/documentation/git/interdiff

Sorry. i must have forgotten.

The same problem occurs with 8.x-6.x-dev. Does this patch work for that?

@amaisano I just tested this out and it works on 6.x-dev version for me. I encountered the same issue, applied the patch and got correct results.

Has this been rolled into the latest dev release yet?

This has not been added to the latest dev. I've re-rolled the patch. Its almost entirely different than the patch in #7 but the resulting queries are the same. Because of the changes on the dev branch, I can't generate an interdiff.

Fixing my own errors. #15 wasn't using the correct logic with that path_cleaner service.

Rerolling for 6.0-alpha2 release

Re-roll patch created, Please review.

Thanks every one for the contribution. Can we just hold this until https://www.drupal.org/files/issues/2020-09-28/2909061-33.patch get committed then we can reroll this one.

I've been using the patch from #21 for awhile and just noticed that using percona database, subqueries are handled completely different.

https://www.percona.com/blog/2010/10/25/mysql-limitations-part-3-subquer...

I've updated the patch to just run the subquery first and use the results raw. It's not good on performance, but it seems to be the only option for Percona databases such as on Acquia hosting.

Adding a check for an empty ids. since doing `WHERE foo IN ()` produces an error.

Correct the logic when no ides are present

Fixing warning errors.

I should've ran my tests first.

Hi @pookmish,

Thanks for the great work on this issue. Is it possible for you to fork and create a PR for the same? If you are in Drupal Slack please give me a ping would love to chat about the same.

Thanks
Rakesh James

Re-rolled to 7.x version

Hi everyone,

Thank you very much for raising this issue and for contributing patches, it's greatly appreciated.

See at #35 the reroll of the MR from this issue fork:
https://git.drupalcode.org/project/views_taxonomy_term_name_depth/-/merg...

Additionnally, please find attached corresponding patch file:
2877249-allow-multiple-values-36.patch

The patch was applied successfully with composer and tested with the following versions:

• views_taxonomy_term_name_depth: 7.1.0
• Drupal: 9.4.3
• pathauto: 1.10.0

 
Feel free to let us know if you encounter any issues, have comments or questions, any feedback would be welcome.
Thanks in advance.

This fix never made it to 7.2.0, merge request failed. And the patch cannot be applied to 7.2.0... Any chance for a patch that works with 7.2.0 or a new release where this is included?

This has been working for us although an update is needed for 7.3.1. Any chance we can get this merged soon?