The module needs to be converted to use short array syntax as per new coding standard.

CommentFileSizeAuthor
#5 invite_array_search_results.png129.93 KBdhruveshdtripathi
#2 invite-2876902-2.patch22.8 KBbandanasharma
#2 interdiff.txt22.8 KBbandanasharma

Comments

bandanasharma created an issue. See original summary.

bandanasharma’s picture

bandanasharma commented
StatusFileSize
new interdiff.txt22.8 KB
new invite-2876902-2.patch22.8 KB

I have created the patch for this. Please review the patch.

bandanasharma’s picture

bandanasharma commented
Status: Active » Needs review
bandanasharma’s picture

bandanasharma commented
dhruveshdtripathi’s picture

dhruveshdtripathi commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new invite_array_search_results.png129.93 KB

Patch applied cleanly. All the arrays converted to short array syntax. Checked it manually. As you can see in the attached png file, earlier here were 79 array declarations, after applying patch there are 0.

Good work!

renatog’s picture

renatog commented
Assigned: Unassigned » renatog
Issue tags: +ciandt-contrib

Thanks guys.

Looks good for me.

  • RenatoG committed 927c4ab on 8.x-1.x authored by bandanasharma 
    Issue #2876902 by bandanasharma, dhruveshdtripathi, RenatoG: Convert...
renatog’s picture

renatog commented
Status: Reviewed & tested by the community » Fixed

Commited in dev branch.

Thanks people.

Regards.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.