Child issue of #2873705: Add change records to all @deprecated code.

Add Change record to @deprecated for LinkUri.php - line 13

CommentFileSizeAuthor
#12 interdiff-2873738-5-12.txt449 bytessorabh.v6
#12 2873738-LinkURI-12.patch1.2 KBsorabh.v6
#5 2873738-LinkURI-5.patch606 bytesedwdeapri
#2 LinkUri.patch601 bytesvrwired

Comments

vrwired created an issue. See original summary.

vrwired’s picture

vrwired commented
StatusFileSize
new LinkUri.patch601 bytes
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Title: Add Change record to @deprecated for LinkUri.php » Add Change record to @deprecated for LinkUri
edwdeapri’s picture

edwdeapri commented

Reviewing patch now - DrupalCon Baltimore Sprints

edwdeapri’s picture

edwdeapri commented
StatusFileSize
new 2873738-LinkURI-5.patch606 bytes

Fixed missing blank line per Drupal Coding Standards

edwdeapri’s picture

edwdeapri commented
Status: Active » Needs review
ohthehugemanatee’s picture

ohthehugemanatee commented
Status: Needs review » Reviewed & tested by the community

Looks good. Thanks!

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Reviewed & tested by the community » Needs review

What was checked? Did we check if all deprecations related to the CR are updated and included in this patch?

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Assigned: Unassigned » heddn

Going to review this here soon. Self assigning.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Needs work

Drupal\menu_link_content\Plugin\migrate\process\d7\InternalUri isn't mentioned in this patch. Let's make sure that all references to the deprecation are caught so we only commit this a single time.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Assigned: heddn » Unassigned
sorabh.v6’s picture

sorabh.v6
He/His
Primary language Hindi
commented
Status: Needs work » Needs review
StatusFileSize
new 2873738-LinkURI-12.patch1.2 KB
new interdiff-2873738-5-12.txt449 bytes

Made changes as per @heddn in comment #10

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Reviewed & tested by the community

This looks good. All references to the change record are caught now.

cilefen’s picture

cilefen commented

Checking some boxes...

  • cilefen committed f3b477f on 8.4.x 
    Issue #2873738 by sorabh.v6, vrwired, edwdeapri, heddn: Add Change...

  • cilefen committed b6e5431 on 8.3.x 
    Issue #2873738 by sorabh.v6, vrwired, edwdeapri, heddn: Add Change...
cilefen’s picture

cilefen commented
Status: Reviewed & tested by the community » Fixed

Committed f3b477f and pushed to 8.4.x. Backported as b6e5431 and pushed to 8.3.x as documentation improvements are allowed in patch releases. Thanks everyone!

xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes
Parent issue: #2873705: Add change records to all @deprecated code »
xjm’s picture

xjm
she/her
Primary language English
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.