I am proposing we fix the automated tests, by removing the module enable for entity_modified,
also, to make it easier to maintain and keep the code more organized, I am proposing we put each class on a separate file

See my branch here: https://github.com/marcelovani/dfp/pull/8/commits

CommentFileSizeAuthor
#3 Screen Shot 2017-04-26 at 18.02.54.png23.27 KBmarcelovani
#2 organize_automated_tests-2873082-2.patch48.02 KBmarcelovani

Comments

marcelovani created an issue. See original summary.

marcelovani’s picture

marcelovani
Primary language Portuguese, Brazil
Location London
commented
Status: Active » Needs review
StatusFileSize
new organize_automated_tests-2873082-2.patch48.02 KB

Adding a patch generated from the fork above

marcelovani’s picture

marcelovani
Primary language Portuguese, Brazil
Location London
commented
Issue summary: View changes
StatusFileSize
new Screen Shot 2017-04-26 at 18.02.54.png23.27 KB
bleen’s picture

bleen commented

I haven't looked through the code in detail, but the idea is an enthusiastic thumbs up from me...

marcelovani’s picture

marcelovani
Primary language Portuguese, Brazil
Location London
commented

Thanks Bleen
The only change in code was to remove 'entity_update' from the list of enabled modules

bleen’s picture

bleen commented
Status: Needs review » Reviewed & tested by the community

Ok ... now i actually looked at the patch :)

LETS DO IT!!

  • bleen committed 64ca210 on 7.x-1.x authored by marcelovani 
    Issue #2873082 by marcelovani: Organize automated tests
bleen’s picture

bleen commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

marcelovani’s picture

marcelovani
Primary language Portuguese, Brazil
Location London
commented

We need to port these tests to the 2.x branch, see https://www.drupal.org/node/2919335