I just notice in ExposedFormPluginBase class function getCacheContexts() has no break statement in a loop.

      /** @var \Drupal\views\Plugin\views\sort\SortPluginBase $sort_handler */
      foreach ($this->displayHandler->getHandlers('sort') as $sort_handler) {
        if ($sort_handler->isExposed()) {
          $has_exposed_sort_handler = TRUE;
        }
      }

      if ($has_exposed_sort_handler) {
        $contexts[] = 'url.query_args:sort_order';
      }

In my view we don't need to continue iteration after $has_exposed_sort_handler is already TRUE

CommentFileSizeAuthor
#20 add_break_statement_in_views_exposed_cache-2872180-20.patch621 bytesnikhil_110
#2 add_break_statement_in_views_exposed_cache-2872180-2.patch621 bytesnikolay shapovalov

Comments

zniki.ru created an issue. See original summary.

nikolay shapovalov’s picture

nikolay shapovalov commented
StatusFileSize
new add_break_statement_in_views_exposed_cache-2872180-2.patch621 bytes
nikolay shapovalov’s picture

nikolay shapovalov commented
Status: Active » Needs review
armrus’s picture

armrus commented
Status: Needs review » Reviewed & tested by the community

Fine.

cilefen’s picture

cilefen commented
Status: Reviewed & tested by the community » Needs work

Thank you for the patch.

Even though this is a small change, I would like to see a test for this cache context. ExposedFormTest is close, but it looks like this particular cache context is being folded/optimized away.

nikolay shapovalov’s picture

nikolay shapovalov commented
Status: Needs work » Needs review

I'm not familiar with writing tests, but in ExposedFormPluginBase there is function testExposedSortAndItemsPerPage().
And all cache context was already tested.

Exact match on cache context to url.query_args:sort_order was removed by https://www.drupal.org/node/2351015 (diff)
So changes is already covered by tests, no new tests needed.

cilefen’s picture

cilefen commented 
+++ b/core/modules/views/src/Plugin/views/exposed_form/ExposedFormPluginBase.php
@@ -356,6 +356,7 @@ public function getCacheContexts() {
           $has_exposed_sort_handler = TRUE;
+          break;

One can comment out $has_exposed_sort_handler = TRUE; yet testExposedSortAndItemsPerPage() passes, so there is no specific test:

Pass      Other      ExposedFormTest.p  363 Drupal\views\Tests\Plugin\ExposedFo
    Value array (
      0 => 'entity_test_view_grants',
      1 => 'languages:language_content',
      2 => 'languages:language_interface',
      3 => 'theme',
      4 => 'url.query_args',
      5 => 'user.permissions',
    ) is identical to value array (
      0 => 'entity_test_view_grants',
      1 => 'languages:language_content',
      2 => 'languages:language_interface',
      3 => 'theme',
      4 => 'url.query_args',
      5 => 'user.permissions',
    ).

Something else is setting a cache context on url.query_args.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Based on #5, adding needs tests tag and setting back to needs work.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

nikhil_110’s picture

nikhil_110 commented
StatusFileSize
new add_break_statement_in_views_exposed_cache-2872180-20.patch621 bytes

Attached patch against drupal 10.1.x

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.