Fix PHPCS & Pareview.sh errors

Patch applied cleanly. All the arrays converted to short array syntax. Checked it manually.

Good work!

The patch doesn't apply to 8x-2.x branch.

Postponing it till #2930410: Display block content in the popup get's in.

Updated the issue to fix all the PHPCS and Pareview errors

Please review my patch # 10.

Thanks for the patch. Please fix the below errors for PHPCS and PHPBP

FILE: ...WebServer/Docroot/popup/modules/popup_dialog/popup_dialog.module
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
 27 | ERROR | [x] Short array syntax must be used to define arrays
 69 | ERROR | [x] Short array syntax must be used to define arrays
 74 | ERROR | [x] Short array syntax must be used to define arrays
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...rver/Docroot/popup/modules/popup_dialog/popup_dialog.routing.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 11 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...ocroot/popup/modules/popup_dialog/src/Form/PopupSettingsForm.php
----------------------------------------------------------------------
FOUND 19 ERRORS AND 1 WARNING AFFECTING 20 LINES
----------------------------------------------------------------------
  37 | ERROR   | [x] Short array syntax must be used to define arrays
  43 | ERROR   | [x] Short array syntax must be used to define arrays
  49 | ERROR   | [x] Short array syntax must be used to define arrays
  52 | ERROR   | [x] Short array syntax must be used to define arrays
  59 | ERROR   | [x] Short array syntax must be used to define arrays
  63 | ERROR   | [x] Short array syntax must be used to define arrays
  64 | ERROR   | [x] Short array syntax must be used to define arrays
  65 | ERROR   | [x] Short array syntax must be used to define arrays
  69 | ERROR   | [x] Short array syntax must be used to define arrays
  96 | ERROR   | [x] Short array syntax must be used to define arrays
 100 | ERROR   | [x] Short array syntax must be used to define arrays
 101 | ERROR   | [x] Short array syntax must be used to define arrays
 102 | ERROR   | [x] Short array syntax must be used to define arrays
 115 | ERROR   | [x] Short array syntax must be used to define arrays
 119 | ERROR   | [x] Short array syntax must be used to define arrays
 120 | ERROR   | [x] Short array syntax must be used to define arrays
 121 | ERROR   | [x] Short array syntax must be used to define arrays
 138 | ERROR   | [x] Short array syntax must be used to define arrays
 145 | ERROR   | [x] Short array syntax must be used to define arrays
 157 | WARNING | [ ] Possible useless method overriding detected
----------------------------------------------------------------------
PHPCBF CAN FIX THE 19 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 171ms; Memory: 4Mb

FILE: ...rver/Docroot/popup/modules/popup_dialog/popup_dialog.routing.yml
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 9 | WARNING | The administration page callback should probably use
   |         | "administer site configuration" - which implies the
   |         | user can change something - rather than "access
   |         | administration pages" which is about viewing but not
   |         | changing configurations.
----------------------------------------------------------------------


FILE: ...ocroot/popup/modules/popup_dialog/src/Form/PopupSettingsForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 85 | WARNING | \Drupal calls should be avoided in classes, use
    |         | dependency injection instead
 86 | WARNING | \Drupal calls should be avoided in classes, use
    |         | dependency injection instead
----------------------------------------------------------------------

Time: 57ms; Memory: 4Mb

Have Fixed the Errors in this patch

NW Please fix the errors listed

Patch attached with all fixed.

Thanks for the patch @Mashir