[D8] Multidomain Google Analytics

Hi @sushilpal!

Your GIT URL is wrong. I could not clone it.
Please take a look and add a Git command like this:

Project Git Url

git clone --branch 8.x-1.x https://git.drupal.org/sandbox/[your_user]/[node_ID].git

For more details about it see: https://www.drupal.org/node/1011698

Nice!

In a first test I found some problems in coding standards and best practices. You can check it using Drupal Coder (https://www.drupal.org/project/coder). To a fast test use it: https://pareview.sh

Take a look in this test: https://pareview.sh/node/1607

Hi sushilpal,

Kindly see the automated review of your project as its showing some errors.

Link: https://pareview.sh/node/1607

Hello @sushilpal!

I tried install your module to take a look in Dependency Injection problem but I received a HTTP ERROR 500 after install.

This is the error in my log:

2017/04/19 16:48:43 [error] 704#0: *126 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Call to a member function id() on null in /www/contrib_modules/multidomain-google-analytics/src/EventSubscriber/GoogleAnalyticResponseSubscriber.php on line 49
PHP message: PHP Stack trace:
PHP message: PHP   1. {main}() /www/d8/docroot/index.php:0
PHP message: PHP   2. Drupal\Core\DrupalKernel->handle() /www/d8/docroot/index.php:19
PHP message: PHP   3. Stack\StackedHttpKernel->handle() /www/d8/docroot/core/lib/Drupal/Core/DrupalKernel.php:656
PHP message: PHP   4. Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() /www/d8/docroot/vendor/stack/builder/src/Stack/StackedHttpKernel.php:23
PHP message: PHP   5. Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() /www/d8/docroot/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php:50
PHP message: PHP   6. Drupal\page_cache\StackMiddleware\PageCache->handle() /www/d8/docroot/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php:47
PHP message: PHP   7. Drupal\page_cache\StackMiddleware\PageCache->pass() /www/d8/docroot/core/modules/page_cache/src/StackMiddleware/PageCache.php:78
PHP message: PHP   8. Drupal\Core\StackMiddleware\KernelPreHandle->handle() /www/d8/docroot/core/modules/page_cache/src/StackMiddleware/PageCache.php:99
PHP message: PHP   9. Drupal\Core\StackMiddleware\Session->handle() /www/d8/docroot/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php:47
PHP message: PHP  10. Symfony\Component\HttpKernel\HttpKernel->handle() /www/d8/docroot/core/lib/Drupal/Core/StackMiddleware/Session.php:57
PHP message: PHP  11. Symfony\Component\HttpKernel\HttpKernel->handleRaw() /www/d8/docroot/vendor/symfony/http-kernel/HttpKernel.php:64
PHP message: PHP  12. Symfony\Component\HttpKernel\HttpKernel->filterResponse() /www/d8/docroot/vendor/symfony/http-kernel/HttpKernel.php:166
PHP message: PHP  13. Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch() /www/d8/docroot/vendor/symfony/http-kernel/HttpKernel.php:184

@sushilpal About your Dependency Injection Warning, you will need change that implementation:

$negotiator = \Drupal::service('domain.negotiator');

For it, use your services.yml file to add the '@domain.negotiator' parameter as a argument for your class constructor. So in your GoogleAnalyticResponseSubscriber class constructor you will add this parameter like you was with the $configFactory.

So in line 48 you won't need more use $negotiator = \Drupal::service('domain.negotiator'); instead it use only some like $this->negotiator.

Hi @sushilpal,

About the error I had the module Domain when I installed your module. I think that can be another problem.
When I installed your module only the main module (Domain) is required, so maybe you are using more.

Are you using only these? Take a look:

Maybe a good idea to prevent it, is do something like that:

$active_domain = $negotiator->getActiveDomain();
if ($active_domain) {
  $domainID = $active_domain->id();
  ...
}

@sushilpal,

After get your updates I uninstall your module and enable all Domain modules. When I enabled your module again I received the error below:

2017/04/19 19:38:37 [error] 703#0: *258 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Call to a member function id() on null in /www/d8/docroot/modules/domain/domain/src/DomainNegotiator.php on line 151
PHP message: PHP Stack trace:
PHP message: PHP   1. {main}() /www/d8/docroot/index.php:0
PHP message: PHP   2. Drupal\Core\DrupalKernel->handle() /www/d8/docroot/index.php:19
PHP message: PHP   3. Stack\StackedHttpKernel->handle() /www/d8/docroot/core/lib/Drupal/Core/DrupalKernel.php:656
PHP message: PHP   4. Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() /www/d8/docroot/vendor/stack/builder/src/Stack/StackedHttpKernel.php:23
PHP message: PHP   5. Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() /www/d8/docroot/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php:50
PHP message: PHP   6. Drupal\page_cache\StackMiddleware\PageCache->handle() /www/d8/docroot/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php:47
PHP message: PHP   7. Drupal\page_cache\StackMiddleware\PageCache->pass() /www/d8/docroot/core/modules/page_cache/src/StackMiddleware/PageCache.php:78
PHP message: PHP   8. Drupal\Core\StackMiddleware\KernelPreHandle->handle() /www/d8/docroot/core/modules/page_cache/src/StackMiddleware/PageCache.php:99
PHP message: PHP   9. Drupal\Core\StackMiddleware\Session->handle() /www/d8/docroot/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php:47
PHP message: PHP  10. Symfony\Component\HttpKernel\HttpKernel->handle() /www/d8/docroot/core/lib/Drupal/Core/StackMiddleware/Session.php:57
PHP message: PHP  11. Symfony\Component\HttpKernel\HttpKernel->handleRaw() /www/d8/docroot/vendor/symfony/http-kernel/HttpKernel.php:64
PHP message: PHP  12. Symfony\Component\HttpKernel\HttpKernel->filterResponse() /www/d8/docroot/vendor/symfony/http-kernel/HttpKernel.php:166
PHP message: PHP  13. Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch() /www/d8/docroot/vendor/symfony/http-kernel/HttpKernel.php:184
PHP message: PHP  14. Drupal\Component\Dep

Hello @sushilpal!

I tested your steps and installed the module without errors.
But normaly when someone will install your module, probably will not have the Domain module installed and configured previously.

So how your module have Domain as a requirement, Drupal will install he first and after that your module automaticaly. After that the Drupal will break and the user cant setup the domain module because all pages are with white screen.

Even if you explain in your module page to setup Domain first is not good user expirence have this error after install in case the user didn't see this rule.

A good solution is resolve it in your code, prevent this error and give to user a way to setup the Domain after install. Maybe in your module configuration page, you can add a message warning the user that he not add your domain yet. And allow the Google Analytics ID field only if exist at least one domain.

Hi Sushil,

You can put a check in GoogleAnalyticResponseSubscriber.php constructor for active domain

    if($negotiator->getActiveDomain()){
          $this->activeDomain = $negotiator->getActiveId();
    }

You can later ask user on module configuration page to first add domain, so that they can use your module.

Hi @sushilpal!

I tested your code again and I didn't have errors to install. At the configuration page I could see the Domain configuration missing and access directly by a link in the message. So sounds good now.

Hi adrianopulz,

should it be RTBC or any other error needs to be worked on?

Hi Sushil,

Module looks good to me. Changing status to RTBC.

Hello @sushilpal!

All looks good. @NarendraR changed to RTBC, thanks.

Thanks for your valuable contribution.
Please specify how this project is different from the google analytics? Please update the issue summary with that, if this is a small feature that can get in google analytics then do that. We encourage collaboration over competition. see https://groups.drupal.org/node/184389#duplicate

There's one also another project https://www.drupal.org/project/domain_analytics Please specify how this project is different from that?

Git clone failed for https://git.drupal.org/sandbox/sushilpal/2836807.git while invoking http://pareview.sh/pareview/httpsgitdrupalorgsandboxsushilpal2836807git

Git clone failed. Aborting.

I'm a robot and this is an automated message from Project Applications Scraper.

Hi @sushilpal module looks proper to me

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.