Problem/Motivation

Various classes in the video_embed_field module place their constructor at the bottom of the class, or inbetween methods. Core classes all place their constructor (and setter injection) before the class's methods. And that is where I was looking for them.

Proposed resolution

To prevent unneeded searching by other developers, I suggest to follow core's pattern.

CommentFileSizeAuthor
#4 video_embed_field-constructor-dx-2867433-4.patch24.77 KBSutharsan
#2 video_embed_field-constructor-dx-2867433-2.patch24.38 KBSutharsan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sutharsan created an issue. See original summary.

Sutharsan’s picture

Sutharsan CreditAttribution: Sutharsan at LimoenGroen commented
Status: Active » Needs review
FileSize
video_embed_field-constructor-dx-2867433-2.patch24.38 KB

Status: Needs review » Needs work

The last submitted patch, 2: video_embed_field-constructor-dx-2867433-2.patch, failed testing.

Sutharsan’s picture

Sutharsan CreditAttribution: Sutharsan at LimoenGroen commented
Status: Needs work » Needs review
FileSize
video_embed_field-constructor-dx-2867433-4.patch24.77 KB

One constructor was deleted instead of moved...

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented

I used to like getting them out of the way, but I agree, we should follow what core does.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Status: Needs review » Fixed

  • Sam152 committed 9eff631 on 8.x-1.x authored by Sutharsan 
    Issue #2867433 by Sutharsan: Improve DX by placing the constructor on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.