Hi,
I am using the module in one of my Drupal 7 multilingual site. I have added translation for "Back to top" text but is not showing.

CommentFileSizeAuthor
#12 translation-support-2865388-12.patch3.16 KBpiyuesh23
#11 interdiff.txt3.32 KBmiteshmap
#11 translation-support-2865388-11.patch3.15 KBmiteshmap
#10 interdiff.txt2.11 KBmiteshmap
#10 translation-support-2865388-10.patch1.6 KBmiteshmap
#9 interdiff.txt2.28 KBmiteshmap
#8 translation-support-2865388-8.patch1.78 KBmiteshmap
#7 2865388-7-d8-translation-support.patch1.05 KBgbisht
#5 Unable_to_translate_Back_to_top_button_text-2865388-#2.patch534 bytesgajanannehul
#2 menu_fields-you_are_not_authorized_to_access_this_page-issue2826319-comment3.patch887 bytesgajanannehul

Comments

gajanannehul created an issue. See original summary.

gajanannehul’s picture

gajanannehul commented
StatusFileSize
new menu_fields-you_are_not_authorized_to_access_this_page-issue2826319-comment3.patch887 bytes

Hi,

Just the t() function was missing attached patch.

gajanannehul’s picture

gajanannehul commented
Assigned: gajanannehul » Unassigned
Status: Active » Needs review
richgerdes’s picture

richgerdes
he/him
Primary language English
Location New Jersey, USA
commented
Status: Needs review » Needs work

@gajanannehul,

It looks like your patch from #2 applies to issue 2826319 for the Menu Fields module, not this issue. Please provide the correct patch for the Back to Top Module.

gajanannehul’s picture

gajanannehul commented
StatusFileSize
new Unable_to_translate_Back_to_top_button_text-2865388-#2.patch534 bytes

OMG!! sorry my bad. I have attached correct patch let me know if any issue.

richgerdes’s picture

richgerdes
he/him
Primary language English
Location New Jersey, USA
commented
Status: Needs work » Reviewed & tested by the community

The patch looks good, and worked for me. Marking as RTBC.

gbisht’s picture

gbisht commented
Version: 7.x-1.5 » 8.x-1.x-dev
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 2865388-7-d8-translation-support.patch1.05 KB

Translation support is not working for D8 as well. So let's first fix this issue for D8.
Adding the patch for latest D8 dev branch.

miteshmap’s picture

miteshmap
Primary language Gujarati
commented
StatusFileSize
new translation-support-2865388-8.patch1.78 KB
  • added all settings to schema.
  • added tab for settings & translations.
miteshmap’s picture

miteshmap
Primary language Gujarati
commented
StatusFileSize
new interdiff.txt2.28 KB
miteshmap’s picture

miteshmap
Primary language Gujarati
commented
StatusFileSize
new translation-support-2865388-10.patch1.6 KB
new interdiff.txt2.11 KB

Removed unnecessary comment.

miteshmap’s picture

miteshmap
Primary language Gujarati
commented
StatusFileSize
new translation-support-2865388-11.patch3.15 KB
new interdiff.txt3.32 KB

Missed schema updated to add into patch.

piyuesh23’s picture

piyuesh23 commented
StatusFileSize
new translation-support-2865388-12.patch3.16 KB

Porting this patch to 8.x-1.0-beta2 version for use on a recent project.

gbisht’s picture

gbisht commented

@miteshmap I don't think we need translation for everything in the module configuration because non of them is the actual text which shows on the website. Other then button text rest is color or related settings, which will be same of all other languages.
@piyuesh we should alway get patch for the dev version. And the patch for dev had only new files so it will work with other version as well.

chris matthews’s picture

chris matthews commented
Priority: Major » Normal
Status: Needs review » Reviewed & tested by the community

2865388-7-d8-translation-support.patch in #7 looks good to me. Per gulab.bisht's comment in #13 I don't think we need translation for everything in the module configuration.

  • acke committed 79784cb on 8.x-1.x authored by gulab.bisht 
    Issue #2865388 by miteshmap, gajanannehul, gulab.bisht, piyuesh23:...
acke’s picture

acke commented
Status: Reviewed & tested by the community » Fixed

Included in 8.x-1.0. Thanks for your help!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.