Closed (fixed)
Project:
Entity Reference Revisions
Version:
8.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
21 Mar 2017 at 15:30 UTC
Updated:
6 Oct 2017 at 11:42 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
kalpaitch commented// @deprecated in Drupal 8.3.x and will be removed before Drupal 9.0.0.
// Use hal.link_manager instead.
Dependency should be on the hal link manager or force an additional dependency on hal.
Comment #3
andypostComment #4
andypostAs 8.2 no longer supported it makes sense to commit
Comment #5
ayalon commentedPlease create a new version. A lot of peoploe will upgrade to 8.3.1 now and this module breaks every page that has paragraphs installed wihtout the patch.
Comment #6
vincejones commentedJust did a fix for this issue locally using composer. You can add this to the "patches" section of your composer.json and run a composer install.
Comment #7
berdir#2849136: EntityReferenceRevisionsServiceProvider should check for rest module "fixed" this by ensuring that rest module is enabled and this was committed to the dev version, so that should work on 8.3.
This makes sense now, but it should remove the check that was added for rest, otherwise the result is that this doesn't run anymore at all when rest module is not enabled.
Comment #8
berdirThis should do the trick.
Comment #9
andypostYes, that's better
Comment #11
miro_dietikerCommitted, thx.
Comment #12
kmetz commentedAdding remove-rest-dependency-2862543-12.patch, which works against 8.x-1.2.
Comment #13
miro_dietikerThat patch doesn't apply, we have committed it already to HEAD. It will be part of the next release.
Comment #15
lpeabody commented@kmetz thank you for the patch.