Either declare as recommendation or required dependency in main package, tending towards the latter.

CommentFileSizeAuthor
#3 declare_externalauth-2861921-3.patch608 bytesdishabhadra

Comments

grahl created an issue. See original summary.

dishabhadra’s picture

dishabhadra commented
Assigned: Unassigned » dishabhadra
dishabhadra’s picture

dishabhadra commented
Status: Active » Needs review
StatusFileSize
new declare_externalauth-2861921-3.patch608 bytes

Review my patch.

Status: Needs review » Needs work

The last submitted patch, 3: declare_externalauth-2861921-3.patch, failed testing.

grahl’s picture

grahl
he/him
Location Zürich
commented

Thanks, indentation is four spaces, could you please fix that?

selvanathan’s picture

selvanathan commented

Should we use four spaces in composer.

https://www.drupal.org/node/2654894

grahl’s picture

grahl
he/him
Location Zürich
commented
Assigned: dishabhadra » Unassigned
Status: Needs work » Needs review

Thanks for that link, I was only aware of the coding guidelines standard for all JS files and did not know of that exception.

  • grahl committed 990d1ed on 8.x-3.x authored by dishabhadra 
    Issue #2861921 by dishabhadra: Declare externalauth dependency with...
grahl’s picture

grahl
he/him
Location Zürich
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.