Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
We use 2 spaces as indentation for composer.json file, but composer itself uses 4 spaces. This leads to unnecessary huge changes in git after people modify the composer.json via composer (e.g. composer require drupal/example) or use the composer_manager init script.
Proposed resolution
Use an indent of 4 spaces for all compsoer.json files and update .editorconfig accordingly.
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#10 | 2654894-10.patch | 21.34 KB | webflo |
#6 | 2654894-6.patch | 173 bytes | felribeiro |
Comments
Comment #2
dawehnerSounds sensible for me! +1
Comment #3
bojanz CreditAttribution: bojanz at Centarro commented+1. Let's do it.
Comment #4
dawehnerComment #5
felribeiro CreditAttribution: felribeiro at CI&T commentedWrong patch.
Comment #6
felribeiro CreditAttribution: felribeiro at CI&T commentedPatch to update .editorconfig
Comment #7
gnugetComment #8
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedThanks, works great with PhpStrom and the Editor Config Plugin.
Comment #9
bojanz CreditAttribution: bojanz at Centarro commentedWe didn't update the actual composer.json files?
Comment #10
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedI thought we do it in a follow-up, but here is the patch.
Comment #11
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedComment #12
dawehnerNice!
Comment #14
catchShame we can't enforce 2 spaces on composer, but the diffs are more important.
Committed/pushed to 8.1.x, thanks!