Following #2603074: Remove |raw from use in core templates we should remove Raw from Zurb templates.

CommentFileSizeAuthor
#11 remove_raw_from_use_in-2856605-11.patch1.47 KBHongPong
#9 after-patch.png21.95 KBbandanasharma
#9 before-patch.png22.06 KBbandanasharma
#7 apply-patch-error.png14.09 KBbandanasharma
#3 zurb_foundation-remove-raw-2856605-2.patch1.14 KBserg2
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

serg2 created an issue. See original summary.

serg2’s picture

serg2 CreditAttribution: serg2 commented
Status: Active » Needs review
serg2’s picture

serg2 CreditAttribution: serg2 commented
FileSize
zurb_foundation-remove-raw-2856605-2.patch1.14 KB
serg2’s picture

serg2 CreditAttribution: serg2 commented
Assigned: serg2 » Unassigned
HongPong’s picture

HongPong CreditAttribution: HongPong as a volunteer and at kor group commented

This seems like a good idea, would improve security overall. +1

kevinquillen’s picture

kevinquillen CreditAttribution: kevinquillen at Velir commented

+1

bandanasharma’s picture

bandanasharma CreditAttribution: bandanasharma as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
FileSize
apply-patch-error.png14.09 KB

I am not able to apply #3 patch. Attached the error image.

serg2’s picture

serg2 CreditAttribution: serg2 commented

I just applied the patch against the latest dev and it applies cleanly.

server:/home/patch/public_html/zurb-foundation# git apply -v zurb_foundation-remove-raw-2856605-2_0.patch
Checking patch templates/html.html.twig...
Applied patch templates/html.html.twig cleanly.
bandanasharma’s picture

bandanasharma CreditAttribution: bandanasharma as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
Status: Needs review » Reviewed & tested by the community
FileSize
before-patch.png22.06 KB
after-patch.png21.95 KB

I have try with latest dev and patch is apply cleanly. I have attached some after and before attachments.

  • HongPong committed 0f377b1 on 8.x-6.x authored by serg2 
    Issue #2856605 by serg2, bandanasharma: Remove |raw from use in...
HongPong’s picture

HongPong CreditAttribution: HongPong as a volunteer and at kor group commented
Version: 8.x-6.x-dev » 8.x-5.x-dev
FileSize
remove_raw_from_use_in-2856605-11.patch1.47 KB

Here is a patch for 8.x-5.x.

  • HongPong committed 5c70df1 on 8.x-5.x 
    Issue #2856605 by serg2, HongPong, bandanasharma: Remove |raw from use...
HongPong’s picture

HongPong CreditAttribution: HongPong as a volunteer and at kor group commented
Status: Reviewed & tested by the community » Fixed

Thank you serg2, bandanasharma, kevinquillen :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.