In the Active toolbar configuration for CKEditor, admins have the ability to add two or more rows of buttons. If the video embed button is placed on a row Other than the first row, it is not recognized and error is shown.

"To embed videos, make sure you have enabled the "Video Embed WYSIWYG" filter and dragged the video icon into the WYSIWYG toolbar. For more information read the documentation."

If the button is moved to the first row, everything is ok.

ckeditor

CommentFileSizeAuthor
#4 2853926-fix-button-rows-validation-4.patch2.49 KBsam152
ckeditor_row2.png113.8 KBjimconte

Comments

jimconte created an issue. See original summary.

jimconte’s picture

jimconte commented
Issue summary: View changes
sam152’s picture

sam152 commented

Good catch. I'll take a look tomorrow.

sam152’s picture

sam152 commented
Status: Active » Needs review
StatusFileSize
new 2853926-fix-button-rows-validation-4.patch2.49 KB

Fix attached.

Status: Needs review » Needs work

The last submitted patch, 4: 2853926-fix-button-rows-validation-4.patch, failed testing.

sam152’s picture

sam152 commented

Fails look like they are in HEAD. Opened #2854146: Fix fails in HEAD..

sam152’s picture

sam152 commented
Status: Needs work » Fixed

  • Sam152 committed f155a31 on 8.x-1.x 
    Issue #2853926 by Sam152, jimconte: Embed Video button not recognized on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.