Deletion of Variable is not proper

Hi @Disha,

Deletion of variables are proper. +1 for RTBC.

But patch have few more changes in age_calculator.helper_functions.inc files. Are these changes are scope of issues?

If no, then it should not be a part of patch. If yes, then we can update the issue summary.

Suggestion on age_calculator.helper_function.inc

diff --git a/age_calculator.helper_functions.inc b/age_calculator.helper_functions.inc
...
+function age_calculator_get_results($date1, $date2) {
+  $output = "";
+  $config = \Drupal::config('age_calculator.settings');
+  // Fetch the configuration from variables table.
+  $age_calculator_output = $config->get('age_calculator_output');
+  // If the configrations are not saved by admin, we shall use the default one.
+  if (empty($age_calculator_output)) {
+    // Fetching the defult configuration.
+    $age_calculator_output = age_calculator_default_output_options();
+  }
+  // Fetching defined variables, based on which output will be displayed.
+  $age_calculator_years_months_days = $age_calculator_output['age_calculator_years_months_days'];
+  $age_calculator_months_days = $age_calculator_output['age_calculator_months_days'];

We can create a services for helper function. So it will be more usable.

Thanks for the #5 @dishabhadra.
Have Committed to new 8.x-2.x branch, Will be creating the release soon.

Thank you for the contribution guys.
I have added a new release that fixes this issue.
Here is 8.x-2.0 release: https://www.drupal.org/project/age_calculator/releases/8.x-2.0.