Remove hard corded HTML from http://cgit.drupalcode.org/google_cse/tree/google_cse.module#n105, and make search message configurable.

CommentFileSizeAuthor
#8 2853400-8.patch2.83 KBabhijith s
#2 no_results_message-2853400-2.patch2.7 KBnavneet0693

Comments

navneet0693 created an issue. See original summary.

navneet0693’s picture

navneet0693 commented
Status: Active » Needs review
StatusFileSize
new no_results_message-2853400-2.patch2.7 KB
navneet0693’s picture

navneet0693 commented
Assigned: navneet0693 » Unassigned
purushotam.rai’s picture

purushotam.rai commented
Status: Needs review » Reviewed & tested by the community

Patch looks good to me.

  • navneet0693 committed 486dc1e on 8.x-2.x 
    Issue #2853400 by navneet0693, purushotam.rai: Make no results message...
navneet0693’s picture

navneet0693 commented
Status: Reviewed & tested by the community » Fixed

Thanks :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

abhijith s’s picture

abhijith s commented
StatusFileSize
new 2853400-8.patch2.83 KB

Patch reroll for 4.0.0-alpha5 version

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented

Thanks for re-rolling the patch. Given that the "no results" message can be customized using Google's Element Control API through the existing settings form in the Drupal site, I don't think there's a strong argument for adding a dedicated field that would in effect be duplicative.

I think we just need to help users know that this _can_ be done through the existing Drupal interface. I've added documentation that specifically calls out customizing the "no results" message at https://www.drupal.org/docs/extending-drupal/contributed-modules/contrib...