Rename and Clean Up "ad_example" Submodule [#2852735]

I've renamed and cleaned up the ad_example submodule as discussed in comment #2 of 7.x re-implementation (7.x-3.x?).

You can view the changes I've made in my ad_ad_ui sandbox.

The bulk of the changes are for renaming the submodule and its pieces to ad_ui. To make it easier to review, I split the changes up among various commits: renaming the module, renaming the content type, renaming the view modes and layouts, renaming the permissions, renaming the views, and then some other commits that fixed minor issues I ran into.

There are still two things lacking that I didn't have time to address:

The displays in the Ad Display view need to be updated manually after installation so that their Ad size filters point to the correct vocabulary and terms. This really should be an automatic process.
There's still very little documentation on how to use the modules. It might be useful to at least show that calling drush ad-ui-install will install the example content. Being able to play around with the example content should get most people to a point where they can easily figure out things on their own.

Comment	File	Size	Author
#4	Aggregate-2852735-4.patch	59.96 KB	tbaumgard
#4	0009-Corrected-typo-in-comment-2852735-4.patch	719 bytes	tbaumgard
#4	0008-Changed-the-example-content-installer-to-use-a-full-2852735-4.patch	1.48 KB	tbaumgard
#4	0007-Removed-redundant-dependency-declaration-2852735-4.patch	577 bytes	tbaumgard
#4	0006-Renamed-views-to-exclude-example-from-their-names-2852735-4.patch	5.19 KB	tbaumgard
#4	0005-Renamed-permissions-to-exclude-example-from-their-na-2852735-4.patch	4.43 KB	tbaumgard
#4	0004-Renamed-view-modes-and-layouts-to-exclude-example-fr-2852735-4.patch	10.31 KB	tbaumgard
#4	0003-Renamed-the-ad_example-content-type-to-ad-2852735-4.patch	16.46 KB	tbaumgard
#4	0002-Renamed-the-ad_example-submodule-to-ad_ui-2852735-4.patch	17.88 KB	tbaumgard
#4	0001-Removed-macOS-desktop-services-files-2852735-4.patch	2.93 KB	tbaumgard

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

15 February 2017 at 01:20

tbaumgard created an issue. See original summary.

Comment #2

tbaumgard CreditAttribution: tbaumgard commented 15 February 2017 at 01:21

Issue summary:

View changes

Comment #3

Jeremy CreditAttribution: Jeremy at Tag1 Consulting commented 17 February 2017 at 14:47

Please submit a patch, and I'll take a look.

Comment #4

tbaumgard CreditAttribution: tbaumgard commented 20 February 2017 at 01:03

File	Size
0001-Removed-macOS-desktop-services-files-2852735-4.patch	2.93 KB
0002-Renamed-the-ad_example-submodule-to-ad_ui-2852735-4.patch	17.88 KB
0003-Renamed-the-ad_example-content-type-to-ad-2852735-4.patch	16.46 KB
0004-Renamed-view-modes-and-layouts-to-exclude-example-fr-2852735-4.patch	10.31 KB
0005-Renamed-permissions-to-exclude-example-from-their-na-2852735-4.patch	4.43 KB
0006-Renamed-views-to-exclude-example-from-their-names-2852735-4.patch	5.19 KB
0007-Removed-redundant-dependency-declaration-2852735-4.patch	577 bytes
0008-Changed-the-example-content-installer-to-use-a-full-2852735-4.patch	1.48 KB
0009-Corrected-typo-in-comment-2852735-4.patch	719 bytes
Aggregate-2852735-4.patch	59.96 KB

Here are the individual patches and a single aggregate patch that I created from the commits in my sandbox via git format-patch ....

Comment #5

28 March 2017 at 15:13

Jeremy committed 25edd2c on 7.x-3.x authored by tbaumgard

Issue #2852735 by tbaumgard: Remove example from view modes and layouts

Jeremy committed 2897345 on 7.x-3.x authored by tbaumgard

Issue #2852735 by tbaumgard: Fix typo in inline documentation

Jeremy committed 2d2a13d on 7.x-3.x authored by tbaumgard

Issue #2852735 by tbaumgard: Remove redundant eck dependency

Jeremy committed 32c7163 on 7.x-3.x authored by tbaumgard

Issue #2852735 by tbaumgard: Remove example from permissions

Jeremy committed 4b5dbbb on 7.x-3.x authored by tbaumgard
```
Issue #2852735 by tbaumgard: Rename views
```

Jeremy committed 742966b on 7.x-3.x authored by tbaumgard

Issue #2852735 by tbaumgard: Rename "ad_example" to "add_ui"

Jeremy committed 8bd75b3 on 7.x-3.x authored by tbaumgard

Issue #2852735 by tbaumgard: Use full path when creating example content

Jeremy committed 9b6df1b on 7.x-3.x authored by tbaumgard

Issue #2852735 by tbaumgard: remove macOS desktop services files

Jeremy committed b455ec2 on 7.x-3.x authored by tbaumgard

Issue #2852735 by tbaumgard: Rename ad_example content type to ad

Comment #6

Jeremy CreditAttribution: Jeremy at Tag1 Consulting commented 28 March 2017 at 15:23

Thanks for your work on this! All patches have been applied.

Regarding #1 in your TODO, as this is a -beta release I don't think it's critical we automate the upgrade path. It would be good to document how this is done manually.

Regarding #2 in your TODO, agreed, more documentation would be super useful.

For future patches, please review:

The Drupal community does not use git format-patch and git apply.

Comment #7

Jeremy CreditAttribution: Jeremy at Tag1 Consulting commented 28 March 2017 at 15:28

Status:

Needs review

» Fixed

Comment #8

tbaumgard CreditAttribution: tbaumgard commented 29 March 2017 at 02:07

For what it's worth, I was trying to follow this guide as opposed to the typical patch workflow because it was such a complex changeset, but thanks for the heads-up and for merging the changes.

Anyway, the first TODO item I mentioned isn't related to upgrades and will happen with a brand-new install. If I remember correctly, and it's been awhile since I've looked into it, I think there are some IDs hard-coded that don't map to the expected vocabulary or taxonomy term IDs unless you're lucky enough to have a setup close to that of the original author. I ended up leaving it go because I wasn't sure what the proper way to handle them was at the time, and I didn't have exactly have a ton of time to investigate it. In any case, I completely agree with you that it's not critical because it's example content anyway.